Resolve issues #431, #437, #438 - #481
Open
laraba9987-cmyk wants to merge 1 commit into
Open
Conversation
…h-Studios#438 - BlockDash-Studios#431: Fix subscription status sync failure on partial payloads with graceful fallbacks, safe event type casting, and default values for missing fields - BlockDash-Studios#437: Add bounds/limits to pathfinding recommendation endpoints with max source amount validation, input length checks, and missing field validation - BlockDash-Studios#438: Add pathfinding caching with TTL-based cache and automatic graph pruning (max 1000 entries, oldest evicted first)
|
@laraba9987-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves 3 assigned issues:
#431 - Bug: Subscription Status Sync Fails When Providers Return Partial Payloads
Fixed partial payload handling by including all available payload fields in webhook delivery, adding safe event type casting with fallback to known types, default values for missing fields (eventId, title, body, occurredAt), and graceful error logging for unknown event types.
#437 - Bug: Pathfinding Recommendation Endpoints Are Unbounded and Can Time Out
Added validation bounds to pathfinding quote endpoint: maximum source amount check (1B), input string length limit, missing required field validation, and non-positive amount rejection. Also implemented the previously empty learningPathService with bounded recommendation logic.
#438 - Enhancement: Add Pathfinding Caching and Graph Pruning for Frequent Lookups
Added in-memory caching to PathfindingService with 60-second TTL, automatic cache pruning when size exceeds 1000 entries (oldest evicted first), and cache key based on asset pair + amount. Exposes clearCache() and getCacheSize() methods.
Closes #431, Closes #437, Closes #438