fix: verify challenge attempt count before accepting submissions in SubmissionService - #498
Merged
MaryammAli merged 3 commits intoJul 28, 2026
Conversation
Learners could previously submit more attempts than allowed by the challenge policy, bypassing the configured limit. - Add attempt limit tracking to ChallengesService with configurable max attempts per challenge (default: 3) - Add POST /challenges/:challengeId/submit endpoint with verification - Add GET /challenges/:challengeId/attempts/:userId status endpoint - Add PUT /challenges/:challengeId/attempts/limit admin endpoint - Add attempt limit check in SubmissionsService.create() for challenge tasks - Record domain events in monitoring when limits are exceeded Closes BlockDash-Studios#359
|
@eulami Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #359
Problem: Learners could submit more attempts than allowed by the challenge policy because the active
SubmissionService(used bySubmissionModule) had no attempt-limit verification. A separateSubmissionsServicewith verification existed but its module was not imported by the app.Changes:
ChallengesServiceandMonitoringServiceinjection toSubmissionServiceSubmissionService.create()andSubmissionService.publishDraft()verifyChallengeAttemptLimit(),recordChallengeAttempt(), andisChallengeTask()helpersChallengesModuleandMonitoringModuleinSubmissionModuleTesting: All 37 tests pass across challenges and submissions modules.