Fix/contract issues 393 396 danieloche635 bit - #501
Merged
MaryammAli merged 4 commits intoJul 28, 2026
Merged
Conversation
…#394, BlockDash-Studios#395, BlockDash-Studios#396 for contract management - BlockDash-Studios#393: Add contract-registry.service.ts with schema compatibility checks - BlockDash-Studios#393: Add env.schema.ts with contract environment variable validation - BlockDash-Studios#393: Update config.module.ts to include contract env var validation - BlockDash-Studios#394: Add event replay and state reconciliation to contracts.service.ts - BlockDash-Studios#394: Add replay job support to jobs.service.ts - BlockDash-Studios#394: Add reconciliation tracking to analytics.service.ts - BlockDash-Studios#394: Add replay/reconciliation reports to reports.service.ts - BlockDash-Studios#395: Gate contract ingestion behind CONTRACT_INGESTION_ENABLED flag - BlockDash-Studios#395: Consolidate duplicate imports in app.module.ts - BlockDash-Studios#395: Track feature flag state in metrics.service.ts - BlockDash-Studios#396: Implement IContractAdapter in contracts.service.ts - BlockDash-Studios#396: Refactor course.service.ts to use contract adapter - BlockDash-Studios#396: Refactor payments.service.ts to use contract adapter - Update contracts.interface.ts with registry, replay, adapter types - Update contracts.module.ts with MonitoringModule import and proper exports
…lockDash-Studios#393-BlockDash-Studios#396 Add comprehensive unit tests for the contracts module: - contracts.service.spec.ts: 80+ tests covering reputation, certificates, badges, payouts, governance, contract invocation/deployment (feature-flagged BlockDash-Studios#395), event log/replay/reconciliation (BlockDash-Studios#394), IContractAdapter methods (BlockDash-Studios#396), and disabled-feature-flag scenarios - contract-registry.service.spec.ts: 25+ tests covering registration validation, schema compatibility (BlockDash-Studios#393), duplicate detection, max-entries enforcement, listing with filters, deregistration, and permissive mode - contracts.controller.spec.ts: 30+ tests covering all 25+ endpoints with proper service mocking and metrics verification Also installs @types/uuid dev dependency for uuid module type declarations.
|
@danieloche635-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #396
closes #395
closes #394
closes #393