Linux support (Page Fault handling, build fixes)#3
Open
PlatinumMaster wants to merge 3 commits into
Open
Conversation
PlatinumMaster
marked this pull request as draft
June 6, 2026 14:48
PlatinumMaster
marked this pull request as ready for review
June 6, 2026 16:06
WhiteTPoison
force-pushed
the
rollback
branch
2 times, most recently
from
June 11, 2026 17:07
22ea663 to
b672d30
Compare
…phin into rollback # Conflicts: # Source/Core/Core/HW/Memmap.cpp
PlatinumMaster
changed the title
| #endif | ||
| // Brawlback | ||
| // We hijack faults first to see if they are expected | ||
| if (Core::System::GetInstance().GetMemory().HandleFault(bad_address)) { |
Member
There was a problem hiding this comment.
You can put this in the below if statement like so (!...GetMemory().HandleFault() && !...GetPPC().HandleFault()) but just a code cleanliness thing, please test to make sure it works
Author
There was a problem hiding this comment.
I can combine the calls, unless there's a specific reason to keep them separate. I'll give this a proper look next week when I'm back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some issues which prevented the emulator from building on Linux, so I corrected those in order to get it built on Linux. This supersedes #2 which aimed to fix the same problem (which I found out after fixing the issues already), but now with the latest GekkoNet/EXI code.