Skip to content

fix: use real start times in playwright reporter under fake timers#930

Merged
devpow112 merged 1 commit into
mainfrom
depowell/playwright-reporter-fake-timer-started
Jun 26, 2026
Merged

fix: use real start times in playwright reporter under fake timers#930
devpow112 merged 1 commit into
mainfrom
depowell/playwright-reporter-fake-timer-started

Conversation

@devpow112

@devpow112 devpow112 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

The Playwright reporter recorded each test's started from the worker-computed result.startTime, which gets corrupted when a test mocks Date (fake timers), producing wrong timestamps. It now records real wall-clock start times in onTestBegin (keyed by test.id) using the RealDate-based getNowISOString helper, matching the node and jest reporters, so it works regardless of whether the clock is mocked to the past or future.

https://desire2learn.atlassian.net/browse/QE-2045

@github-actions github-actions Bot added the javascript Pull requests that update JavaScript code label Jun 26, 2026
@devpow112 devpow112 added the bug Something isn't working label Jun 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Report

Report Validation

jest 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

mocha 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

node 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

playwright 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

@web/test-runner 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

webdriverio 🟢

Schema: PASSED 🟢
Contents: PASSED 🟢

Report

@devpow112 devpow112 marked this pull request as ready for review June 26, 2026 18:20
@devpow112 devpow112 requested a review from a team as a code owner June 26, 2026 18:20
@devpow112 devpow112 enabled auto-merge (squash) June 26, 2026 18:20
@devpow112 devpow112 merged commit 173e2f1 into main Jun 26, 2026
5 checks passed
@devpow112 devpow112 deleted the depowell/playwright-reporter-fake-timer-started branch June 26, 2026 18:30
@d2l-github-release-tokens

Copy link
Copy Markdown

🎉 This PR is included in version 6.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@d2l-github-release-tokens d2l-github-release-tokens Bot added the released Pull requests that have been released label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update JavaScript code released Pull requests that have been released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants