Add initial rail generator implementation#86
Merged
Merged
Conversation
MineFact
requested changes
May 18, 2026
MineFact
left a comment
MineFact
left a comment
Member
There was a problem hiding this comment.
Your current RailScript does not use the already existing Generator Library at all. AI basically tried to reinvent everything from scratch adding boilerplate code for every action that its currently trying to achieve. For this simple rail track this might work ok but as soon as it will get more complex this will create lots of issues and duplicated code. Please implement the rail generator the same way the road or house generator is implemented. If you can't do this yourself tell AI to first explore the repository and understand how the other generators are working. I can't accept this PR in this current state.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Zoriot
requested changes
Jun 6, 2026
Zoriot
left a comment
Zoriot
left a comment
Collaborator
There was a problem hiding this comment.
User feedback is still horrible. The Message you now get is nice to have.
Maybe it's useful to move some part's of the preparing stage into actual execution phase.
Currently it's very easy to crash the server, i think we should have additional safeguards for that (can be reproduced on dev server).
Also another issue you can currently start it multiple times and/or you get a faulty error message that you have no valid selection.
Seems to be relative resource heavy
Jasupa
force-pushed
the
rail-generator
branch
2 times, most recently
from
cbf658e to
918d88e
Compare
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Zoriot
added
⏰ medium priority
Zoriot
requested changes
Jun 18, 2026
Zoriot
requested changes
Jun 20, 2026
Jasupa
changed the title
Jasupa
changed the title
Zoriot
requested changes
Jun 22, 2026
Jasupa
force-pushed
the
rail-generator
branch
2 times, most recently
from
accf928 to
02957b8
Compare
- collapse generator help output into one component message - move generator documentation link formatting into GeneratorComponent - reuse shared documentation messaging from the generator menu - use ChatHelper success components for generator success feedback - combine undo and redo feedback into single prefixed messages - keep secondary undo and redo action lines unprefixed - simplify rail selection validation by calling checkForPlayer directly - format rail generator limit messages through ChatHelper placeholders - combine generator command failure logs into single exception logs - use ChatHelper for generator failure action bar text - restore the main config version to 1.4 - set the generator module config version to 0.1 - use appendNewline for multi-line generator feedback
Zoriot
previously approved these changes
Jun 22, 2026
Zoriot
left a comment
Zoriot
left a comment
Collaborator
There was a problem hiding this comment.
Have not verified the core logic again & after the latest changes no way to test it ingame. Generally looks good trough
MineFact
previously approved these changes
Jun 22, 2026
MineFact
left a comment
MineFact
left a comment
Member
There was a problem hiding this comment.
I didn't test it yet but looked through the code and it looks fine to me.
kyanvde
requested changes
Jun 22, 2026
kyanvde
approved these changes
Jun 23, 2026
kyanvde
left a comment
kyanvde
left a comment
Contributor
There was a problem hiding this comment.
LGTM as long as the logic still works
- derive generator subcommands, help output and tab completion from GeneratorType - resolve generator command execution through GeneratorType components - document rail generation default limits and hard caps - clarify PositionKey block-coordinate conversion for Bukkit vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an initial implementation of the rail generator and re-enables
/gen rail.Changes
Milanote
https://app.milanote.com/1WgUAs1mA492a6?p=9H9SRXRJA3f