Refactor filtering method to be case-insensitive#72
Open
wong-nw wants to merge 6 commits into
Open
Conversation
Update to filter_cells.R to permit case-insensitivity on filtering method when using function manually
kelly-sovacool
requested changes
Jun 22, 2026
| )] <- "keep" | ||
| } else { | ||
| warning( | ||
| "No valid filtering method selected. All cells with nFeature_RNA > 200 retained" |
Member
There was a problem hiding this comment.
Don't hard-code this number
Suggested change
| "No valid filtering method selected. All cells with nFeature_RNA > 200 retained" | |
| glue::glue("No valid filtering method selected. All cells with nFeature_RNA > {nFeature_RNA_min} retained") |
p.s. is this statement in the warning message accurate? I don't see any filtering logic, so it looks like all cells are kept?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Minor bug fix to filter_cells.R to permit case-insensitivity on filtering method when using function manually
Issues
No issue opened
PR Checklist
(
Strikethroughany points that are not applicable.)[ ] Write unit tests for any new features, bug fixes, or other code changes.[ ] Update the docs if there are any API changes (roxygen2 comments, vignettes, readme, etc.).[ ] UpdateNEWS.mdwith a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.htmldevtools::check()locally and fix all notes, warnings, and errors.R-CMD-checksucceeds on the most recent user commit.