add(faser): new models and transformation rules#525
Conversation
zubeydecivelek
force-pushed
the
faser-model
branch
from
449b371 to
ad9f970
Compare
zubeydecivelek
force-pushed
the
faser-model
branch
3 times, most recently
from
5a1ae44 to
b80fdd9
Compare
zubeydecivelek
force-pushed
the
faser-model
branch
2 times, most recently
from
5c9c961 to
c5cb66e
Compare
zubeydecivelek
changed the title
zubeydecivelek
force-pushed
the
faser-model
branch
6 times, most recently
from
53f5e25 to
b178502
Compare
| # -*- coding: utf-8 -*- | ||
| # | ||
| # Copyright (C) 2026 CERN. | ||
| # |
There was a problem hiding this comment.
we should not have to add another set of rules for faser, but adapt the one for research - you are duplicating a lot of rules here
There was a problem hiding this comment.
I'm only duplicating 690 and 980
| model.over("related_ids", "(^773__)", override=True)(faser_publication_related_ids) | ||
|
|
||
|
|
||
| @model.over("status", "(^591__)", override=True) |
There was a problem hiding this comment.
so we'll ignore this status?
| """Translation model for FASER publication records.""" | ||
|
|
||
| __query__ = ( | ||
| "693__:FASER -591__:Draft AND (" |
There was a problem hiding this comment.
we don't need two separate models for draft and record of faser if we remove -591__:Draft from the query, the model with match all drafts and published records
| "980__.a:NOTE OR " | ||
| "(980__.a:CONFERENCEPAPER OR 980__.a:SLIDE OR 980__.a:CONFERENCENOTE) OR " | ||
| "((980__.a:ARTICLE OR 980__.a:PREPRINT) -980__.a:CONFERENCEPAPER)" |
There was a problem hiding this comment.
is this part of the query needed? Isn't it enough to match by 693__:FASER? we want to move all faser documents, don't we?
| "EligibilityHRCirc": ["eligibility-retr-actual", "hr-web-gacepa"], | ||
| "CERNPeopleEligibility": ["cern-personnel", "eligibility-retr-actual"], | ||
| "FAPDepRestrFile": ["fap-dep"], | ||
| "EP Restricted Draft": ["faser-all"], |
There was a problem hiding this comment.
this is not entirely true, it will be only for Faser, otherwise if there is another collection later which has EP Restricted Draft on the file status, then you will grant access on those other files to faser-all e-group
There was a problem hiding this comment.
I think it's just a status there's no corresponding group
https://gitlab.cern.ch/cds-team/cds-legacy/-/blob/master/src/wn-cdsweb/lib/python/invenio/websubmit_functions/EPPHAPP_Publish_Paper.py#L65
| grid_value = None | ||
| for aff in _affiliations: | ||
| if aff: | ||
| if aff.startswith("GRID:"): |
There was a problem hiding this comment.
can we simply assign the grid if grid is present? I don't think we got the answers which would help us decide otherwise
There was a problem hiding this comment.
you mean adding like this?
affiliations.append(aff)
in this case it might be confusing for users?
values are like this: GRID:grid.6451.6
zubeydecivelek
force-pushed
the
faser-model
branch
from
b178502 to
ecbe233
Compare
zubeydecivelek
force-pushed
the
faser-model
branch
from
ecbe233 to
c7c9763
Compare
2 participants
No description provided.