Skip to content

rdm: configuration and set up aleph,lcd & re29 collections#527

Merged
kpsherva merged 7 commits into
CERNDocumentServer:masterfrom
0einstein0:migration-drafts
Jul 10, 2026
Merged

rdm: configuration and set up aleph,lcd & re29 collections#527
kpsherva merged 7 commits into
CERNDocumentServer:masterfrom
0einstein0:migration-drafts

Conversation

@0einstein0

@0einstein0 0einstein0 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

TODO: In case of missing reviewer user/group, raise warning and create a new user/group.
In marc right now only the user display name is present so not easy to distinguish as multiple users could have the same name.

@0einstein0 0einstein0 linked an issue Jun 4, 2026 that may be closed by this pull request
@0einstein0 0einstein0 changed the title rdm: configured streams and models for aleph,lcd & re29 rdm: configuration and set up aleph,lcd & re29 collections Jun 4, 2026
@0einstein0 0einstein0 force-pushed the migration-drafts branch 3 times, most recently from f7ee389 to c3d95b5 Compare June 4, 2026 12:57
@0einstein0 0einstein0 marked this pull request as ready for review July 2, 2026 08:57
Comment thread cds_migrator_kit/rdm/streams.yaml Outdated
missing_users: cds_migrator_kit/rdm/data/users
communities_ids:
- ""
lcd:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lcd:
lcd_restr:

because I have other public docs there and I want to avoid conflicts in config

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is already a lcd_restr and re29_restr in former_exp as well, should I register these with the same config name?

Comment thread cds_migrator_kit/rdm/streams.yaml Outdated
- ""
load:
legacy_pids_to_redirect: cds_migrator_kit/rdm/data/lep_exp/lcd/duplicated_pids.json
re29:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
re29:
re29_restr:

same reason as above

# but then we get a double redirection
legacy_recid_minter(legacy_recid, record._record.parent.model.id)

def _after_publish_add_inclusion_request(self, request_data, record, entry):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do we later avoid conflict with an existing request when we migrate comments (in separate migration step?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the records had no comments and in comments migration script it already filters out the records with no associated comments

@kpsherva kpsherva left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for implementing this, I've added some comments and questions. Could you add a simple test as well ?

@0einstein0 0einstein0 force-pushed the migration-drafts branch 2 times, most recently from 3f2f0d6 to 552108b Compare July 6, 2026 09:12
@kpsherva kpsherva force-pushed the migration-drafts branch from 552108b to 29bc897 Compare July 9, 2026 11:35
@kpsherva kpsherva merged commit 7609081 into CERNDocumentServer:master Jul 10, 2026
2 checks passed
@kpsherva kpsherva mentioned this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new function: migrate draft to draft

2 participants