rdm: configuration and set up aleph,lcd & re29 collections#527
Conversation
f7ee389 to
c3d95b5
Compare
c3d95b5 to
3717afa
Compare
3717afa to
64ddbcb
Compare
| missing_users: cds_migrator_kit/rdm/data/users | ||
| communities_ids: | ||
| - "" | ||
| lcd: |
There was a problem hiding this comment.
| lcd: | |
| lcd_restr: |
because I have other public docs there and I want to avoid conflicts in config
There was a problem hiding this comment.
there is already a lcd_restr and re29_restr in former_exp as well, should I register these with the same config name?
| - "" | ||
| load: | ||
| legacy_pids_to_redirect: cds_migrator_kit/rdm/data/lep_exp/lcd/duplicated_pids.json | ||
| re29: |
There was a problem hiding this comment.
| re29: | |
| re29_restr: |
same reason as above
| # but then we get a double redirection | ||
| legacy_recid_minter(legacy_recid, record._record.parent.model.id) | ||
|
|
||
| def _after_publish_add_inclusion_request(self, request_data, record, entry): |
There was a problem hiding this comment.
how do we later avoid conflict with an existing request when we migrate comments (in separate migration step?)
There was a problem hiding this comment.
all the records had no comments and in comments migration script it already filters out the records with no associated comments
kpsherva
left a comment
There was a problem hiding this comment.
Hello! Thanks for implementing this, I've added some comments and questions. Could you add a simple test as well ?
3f2f0d6 to
552108b
Compare
552108b to
29bc897
Compare
TODO: In case of missing reviewer user/group, raise warning and create a new user/group.
In marc right now only the user display name is present so not easy to distinguish as multiple users could have the same name.