feat(rdm.migration): Configurable auto-adding secondary community#544
Open
sakshamarora1 wants to merge 1 commit into
Open
Conversation
kpsherva
reviewed
Jul 2, 2026
|
|
||
| # Public research publication resource types that are auto-included in the CERN Research community. | ||
| PUBLIC_RESEARCH_RESOURCE_TYPES = { | ||
| # "publication-dissertation", # Already included by the migrator for thesis records. |
Contributor
There was a problem hiding this comment.
can you add it for completeness? especially useful in case we missed any thesis records in the past migrations...
kpsherva
reviewed
Jul 2, 2026
| communities = record.get("communities", []) | ||
| communities = self.communities_ids + [slug for slug in communities] | ||
|
|
||
| scientific_community = current_app.config.get( |
Contributor
There was a problem hiding this comment.
can you add a failsafe like in the other PRs to check if the variable is set? does it fail silently now? maybe it makes sense to add this case to tests
sakshamarora1
force-pushed
the
feat/add_publications_to_cern_research
branch
from
bf187da to
4eab511
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #542
https://codimd.web.cern.ch/g3bn8n7LRimDeil-TDDIlA