feat(setup): Update pythong version to 3.12 for RDM#545
Conversation
| sentry-sdk>=1.45,<2.0.0 | ||
| cds-dojson @ git+https://github.com/CERNDocumentServer/cds-dojson@master#egg=cds-dojson | ||
| invenio-rdm-migrator>=5.0.0 | ||
| setuptools<82.0.0 # `invenio-rdm-migrator` has a dependency on `pypeln` which depends on `pkg_resources` |
There was a problem hiding this comment.
what about the invenio-query-parser dependency we discussed?
There was a problem hiding this comment.
is pypeln needed in invenio-migrator? can we eliminate it? otherwise we are not upgrading for performance if we depend on older setuptools and calling pkg_resources somewhere in the code
There was a problem hiding this comment.
Invenio-query-parser problem is described above in the setup.cfg file
As for pypeln yes it's being used: https://github.com/search?q=repo%3Ainveniosoftware%2Finvenio-rdm-migrator%20pypeln&type=code
It could be possible to remove it from invenio-rdm-migrator, should I check with Alex?
There was a problem hiding this comment.
is it used for anything? If not then we can remove without involving Alex
There was a problem hiding this comment.
Yes
It is used for multi processing, in the transform run step and either we need to find an alternative for it or pin setuptools
There was a problem hiding this comment.
can you finalise the upgrade without pinning setuptools?
| import collections | ||
| import collections.abc | ||
|
|
||
| collections.MutableMapping = collections.abc.MutableMapping | ||
| collections.Sequence = collections.abc.Sequence |
There was a problem hiding this comment.
will this work in production image? for some time we will need backwards compatibility with 3.9 until we update invenio image to run newer versions
There was a problem hiding this comment.
No it is a breaking change, in python3.10
for backwards compatibility, i can add a try catch
There was a problem hiding this comment.
please make it work in both 3.9 and higher version because we are not yet ready to switch the prod image
2 participants
closes: #543