feat(assets): Switch to pnpm and rspack#832
Conversation
| executeSearch(defaultRun, ""); | ||
| } | ||
| }, []); | ||
| }, [currentQueryState, runs, defaultRun]); |
There was a problem hiding this comment.
could you check this warning?
| @@ -0,0 +1 @@ | |||
| lockfile=false No newline at end of file | |||
| @@ -0,0 +1,12382 @@ | |||
| lockfileVersion: '9.0' | |||
There was a problem hiding this comment.
this is quite sensitive change. If I remember correctly package-lock.json is used to build our deployment images - did you adapt that to the change, will the image still build correctly?
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "cds-rdm-site", | |||
There was a problem hiding this comment.
why do we need to add package.json here?
There was a problem hiding this comment.
I am also confused about this, it would maybe make sense if it was included as a workspace in the root level package.json and all of the dependencies were instead listed here. But I'm not sure why it's necessary in the current form.
| - name: Use Node.js v20.x | ||
| uses: actions/setup-node@v6 | ||
| - name: Install pnpm | ||
| uses: pnpm/action-setup@v4 |
There was a problem hiding this comment.
Any reason why we are not using v6 of the pnpm action?
| @@ -0,0 +1,17 @@ | |||
| { | |||
| "name": "cds-rdm-site", | |||
There was a problem hiding this comment.
I am also confused about this, it would maybe make sense if it was included as a workspace in the root level package.json and all of the dependencies were instead listed here. But I'm not sure why it's necessary in the current form.
3 participants
No description provided.