feat: add ATOM related identifier scheme#836
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
TahaKhan998
force-pushed
the
feat/issue-786-atom-related-identifiers
branch
2 times, most recently
from
3772375 to
c73e9f2
Compare
TahaKhan998
force-pushed
the
feat/issue-786-atom-related-identifiers
branch
from
c73e9f2 to
3238baf
Compare
kpsherva
reviewed
Jul 2, 2026
|
|
||
| def is_atom(val): | ||
| """Test if argument is a non-empty ATOM identifier.""" | ||
| return bool(str(val).strip()) |
Contributor
There was a problem hiding this comment.
how do you know what format atom ID has?
TahaKhan998
force-pushed
the
feat/issue-786-atom-related-identifiers
branch
from
3238baf to
4c05354
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #786
Adds ATOM as a CDS-specific related identifier scheme so it can be selected in the Related works section like the other CDS-only schemes. The change keeps the implementation consistent with the existing project pattern by registering the scheme in CDS config, adding the validator/normalizer in schemes.py, and updating the test config accordingly.