Add KNoT Type IDs: acceleration and angular velocity - #7
Open
luigiluz wants to merge 2 commits into
Open
Conversation
luigiluz
changed the title
vitbaq
approved these changes
Jan 8, 2020
luigiluz
force-pushed
the
knot-type-acceleration
branch
2 times, most recently
from
January 13, 2020 18:01
1288fda to
823adf5
Compare
pauloserrafh
left a comment
pauloserrafh
left a comment
Contributor
There was a problem hiding this comment.
nitpick on 823adf commit message: KNOT should be KNoT
vitbaq
self-requested a review
January 22, 2020 14:39
tgfb
requested changes
Jan 22, 2020
tgfb
left a comment
tgfb
left a comment
Collaborator
There was a problem hiding this comment.
Please review revision comments and perform requested changes.
added 2 commits
January 22, 2020 14:06
Add KNoT Type ID acceleration using m/s² as unit.
Add angular velocity KNOT Type ID with units rad/seg and deg/seg.
luigiluz
force-pushed
the
knot-type-acceleration
branch
from
January 22, 2020 17:14
823adf5 to
d19fb92
Compare
pauloserrafh
self-requested a review
January 22, 2020 17:31
pauloserrafh
approved these changes
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new KNoT Type IDs: