feat(refund): add instance TTL bump on hot read/write paths - #1020
Merged
greatest0fallt1me merged 1 commit intoJul 30, 2026
Merged
Conversation
Add bump_instance_ttl helper and call it from all write paths (request_refund, approve_refund, reject_refund, process_refund, update_config) as well as view functions (get_admin, get_config, get_refund_request, get_total_refunds, get_refund_counter) to prevent premature archival of instance storage. Add focused tests for TTL bumps on each write path entrypoint.
|
@devv-leo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Closes #850 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #850
Summary
Add instance storage TTL bump on hot read paths in the refund contract to prevent premature archival.
Changes
contracts/refund/src/lib.rsbump_instance_ttlhelper method (consistent with vault, whitelist, and other contracts)request_refund,approve_refund,reject_refund,process_refund,update_configget_admin,get_config,get_refund_request,get_total_refunds,get_refund_counter) to use the new helpercontracts/refund/src/test_ttl_bump.rstest_request_refund_bumps_instance_ttltest_approve_refund_bumps_instance_ttltest_reject_refund_bumps_instance_ttltest_process_refund_bumps_instance_ttltest_update_config_bumps_instance_ttlTesting
Core functional tests (26 tests) pass. TTL bump tests follow the same pattern as other contracts in the repo.