fix(#744): polish MethodChip layout for narrow (≤375px) viewports - #813
Open
garfieldxxx1 wants to merge 1 commit into
Open
fix(#744): polish MethodChip layout for narrow (≤375px) viewports#813garfieldxxx1 wants to merge 1 commit into
garfieldxxx1 wants to merge 1 commit into
Conversation
…wports (Closes CalloraOrg#744) Audit MethodChip for narrow mobile viewports (≤375px): enlarged tap targets (44×44px, WCAG 2.5.5), responsive padding/margin wrapping, fix pre-existing class name mismatch (.method-icon → .method-chip-icon), and add comprehensive test coverage with 9 focused tests.
|
@garfieldxxx1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR audits the MethodChip component for narrow mobile viewports (≤375px). Tap targets are enlarged to meet WCAG 2.5.5 minimum 44×44px, padding and margins are increased for better touch interaction, and the chip layout now wraps gracefully when multiple chips overflow the viewport.
Related Issue
Closes #744
Changes
src/components/MethodChip.css— Add@media (max-width: 375px)breakpoint with enlarged padding (10px 14px), 44px min-height, increased font-size, larger icon gap, and adjusted tooltip styling. Base styles also improved with increased min-height (32px) and padding.src/components/MethodChip.test.tsx— Add 9 focused tests covering render, focus, tooltip, CSS class contract for responsive breakpoints, design-token color usage, and fallback colors for unknown methods.Verification Results
Timeline