feat: OnboardingTour with WCAG 2.1 AA keyboard focus outlines (FWC26) - #820
Open
Legit003 wants to merge 1 commit into
Open
feat: OnboardingTour with WCAG 2.1 AA keyboard focus outlines (FWC26)#820Legit003 wants to merge 1 commit into
Legit003 wants to merge 1 commit into
Conversation
- Add src/pages/OnboardingTour.tsx: 5-step guided tour with full keyboard accessibility (WAI-ARIA tabs pattern, skip link, focus management, arrow-key navigation, completion screen) - Add src/pages/OnboardingTour.test.tsx: 48 tests covering rendering, button/keyboard navigation, skip link, completion screen, ARIA attributes, and focus.css @layer contract - Update src/styles/focus.css: add :focus-visible rules for all 6 OnboardingTour interactive element classes inside @layer focus (.onboarding-tour__skip, .tour-step-tab, .onboarding-tour__panel, .tour-nav-button, .tour-done-button, .tour-restart-link) plus a catch-all .onboarding-tour *:focus-visible belt-and-braces rule - Register /onboarding-tour route in src/App.tsx WCAG 2.1 AA compliance: 2.1.1 Keyboard: every interactive element reachable by keyboard alone 2.4.7 Focus Visible: 2px solid var(--accent) ring on :focus-visible 1.4.11 Non-text Contrast: accent token clears 3:1 on both themes 4.1.2 Name/Role/Value: role=tablist/tab/tabpanel, aria-selected, aria-controls, aria-live=polite, explicit aria-labels Closes #FWC26-onboarding-tour
|
@Legit003 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WCAG 2.1 AA compliance:
2.1.1 Keyboard: every interactive element reachable by keyboard alone 2.4.7 Focus Visible: 2px solid var(--accent) ring on :focus-visible 1.4.11 Non-text Contrast: accent token clears 3:1 on both themes 4.1.2 Name/Role/Value: role=tablist/tab/tabpanel, aria-selected, aria-controls, aria-live=polite, explicit aria-labels
Closes #739