feat: add LatencyChart page with HelpPopover for P95 metric explanation - #822
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Conversation
- Create src/pages/LatencyChart.tsx with responsive bar chart and stat cards - Integrate HelpPopover next to chart title explaining P95 latency for first-time users - Add className prop to HelpPopover for layout alignment flexibility - Include LatencyChart.test.tsx with focused accessibility and rendering tests - Update HelpPopover.test.tsx to cover className forwarding - Add page-specific CSS and focus-visible styles in index.css and focus.css - Register /latency-chart route in main.tsx
|
@ololadedavidvictor-bit Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
LGTM 🎉 merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/pages/LatencyChart.tsxwith a responsive bar chart and summary stat cards (min, avg, P95, max)HelpPopovernext to the chart title to explain P95 latency to first-time usersclassNameprop toHelpPopoverfor flexible layout alignmentLatencyChartrendering, accessibility, and HelpPopover integrationHelpPopover.test.tsxto coverclassNameforwarding:focus-visiblestyles inindex.cssandfocus.css/latency-chartroute inmain.tsxAccessibility (WCAG 2.1 AA)
aria-labelandaria-describedbyrole="img"andaria-labelfor screen readers--accentDesign tokens & theme
--surface,--accent,--muted, etc.)Test plan
npx vitest run src/components/HelpPopover.test.tsx src/pages/LatencyChart.test.tsxCloses #714
Closes #678
Closes #679
Closes #686