feat(MethodChip): responsive fixes and a11y improvements (GrantFox FW… - #829
Merged
greatest0fallt1me merged 3 commits intoJul 29, 2026
Conversation
…C26) - Fix CSS token suffix: --method-<verb>-fg → --method-<verb>-color - Fix icon wrapper class: .method-icon → .method-chip-icon - Add ::before pseudo-element for WCAG 2.1 AA §2.5.5 44×44px tap target - Add @media (max-width: 375px) breakpoint: tighter padding, min-width 52px - Add text-overflow: ellipsis via .method-chip-label span (no wrapping) - Add :focus-visible ring using --accent token (2px solid, 3px offset) - Add 36 focused Vitest tests covering all fixes and a11y contracts - Add docs/MethodChip-responsive-fwc26.md change log Closes #FWC26
|
@obafemimathew01-hue Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
CI passed, solid PR — merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(MethodChip): responsive fixes & WCAG 2.1 AA improvements (GrantFox FWC26)
Summary
Audits and fixes MethodChip for narrow viewports (≤375 px), tap-target compliance, text
overflow, and two pre-existing CSS bugs that caused incorrect colours and broken icon spacing.
Changes
Bug fixes
were rendering with wrong foreground text colour in both light and dark themes because the
token name didn't match the definitions in src/index.css.
selector never matched, so icon right-margin was never applied and the icon sat flush against
the label text.
Responsive (≤375 px)
reduces min-width (68px → 52px), and shrinks icon margin. Prevents endpoint-card rows from
overflowing on iPhone SE / narrow Android devices.
WCAG 2.1 AA §2.5.5 — tap target
max(100%, 44px) without changing the visual chip size. pointer-events: none keeps it purely
cosmetic.
Text overflow
only the text and not the icon. The chip is now single-line at any width.
Focus ring
focus treatment in src/styles/focus.css.
Tests
36 new Vitest unit tests in src/components/MethodChip.test.tsx covering:
All 36 tests pass. No regressions in other test files.
Documentation
docs/MethodChip-responsive-fwc26.md — full change log, before/after table, accessibility
compliance matrix, design tokens referenced, and test run instructions.
Checklist
closes Polish MethodChip layout for narrow (mobile) viewports [b#027] #704