feat(print): hide chrome + expand collapsibles when printing ReviewsTab - #833
Open
brooksdevon001-star wants to merge 2 commits into
Open
feat(print): hide chrome + expand collapsibles when printing ReviewsTab#833brooksdevon001-star wants to merge 2 commits into
brooksdevon001-star wants to merge 2 commits into
Conversation
GrantFox FWC26 — ReviewsTab print support - Add `data-reviews-section` attribute to the reviews <section> as a CSS scope anchor for all print rules - Add `reviews-sort-controls no-print` class to the sort-by row so the sort dropdown is hidden on print - Add `no-print` to the Write a Review button (interactive, meaningless on paper) - Add `reviews-list` class to the review cards grid for stable print targeting - Extend `@media print` in index.css with [data-reviews-section] rules: expand all review cards (max-height: none, overflow: visible), expand aria-hidden/[hidden]/details collapsibles, force single-column grid, add break-inside: avoid per card - Add 13 focused contract tests in ReviewsTab.print.test.ts - Add docs/ReviewsTab-print.md documenting the change All 13 new tests pass. No regressions in existing print.test.ts (10/10).
|
@brooksdevon001-star Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(print): hide chrome + expand collapsibles when printing ReviewsTab [FWC26]
───────────────────────────────────────────────────────────────────────────────────────────────
Summary
Fixes the print experience for the Reviews tab on the API Detail page (GrantFox FWC26). When a
user prints Cmd/Ctrl+P while on the Reviews tab, interactive chrome is now hidden and all
review content is fully expanded — nothing is clipped or cut off.
What changed
src/pages/ApiDetailPage.tsx
order is irrelevant on paper)
src/index.css
Details
collapsibles inside the panel —future-proofs against JS-driven collapse patterns
src/pages/ReviewsTab.print.test.ts (new)
main.tsx print.css import guard
docs/ReviewsTab-print.md (new)
accessibility notes, browser compatibility
Testing
npm test -- --run
13 new tests pass. Existing src/print.test.ts (10 tests) continues to pass. No regressions.
Notes
No separate print.css was created — the existing contract test asserts all print styles must
live in src/index.css.
Closes #688