Cycle round-robin per experiment in within-subject experiment#3197
Open
bcb37 wants to merge 4 commits into
Open
Cycle round-robin per experiment in within-subject experiment#3197bcb37 wants to merge 4 commits into
bcb37 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts how repeated-enrollment counts are computed and passed into within-subject assignment logic, with the goal of influencing round-robin cycling behavior for within-subject experiments.
Changes:
- Replaces per-decision-point repeated enrollment lookup with a single aggregated
repeatedEnrollmentCountvalue. - Flattens collection of active decision points via
flatMapand sums counts fromRepeatedEnrollmentRepository.getRepeatedEnrollmentCount(...). - Updates
mapDecisionPoints(...)to take a numericrepeatedEnrollmentCountinstead of an array of per-decision-point counts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+22
to
+26
| .leftJoin('repeatedEnrollment.individualEnrollment', 'ie') | ||
| .leftJoin('ie.experiment', 'experiment') | ||
| .where('ie.userId = :userId', { userId }) | ||
| .andWhere('ie.partitionId IN (:...decisionPointsIds)', { decisionPointsIds }) | ||
| .groupBy('ie.userId , ie.partitionId , ie.id') | ||
| .andWhere('ie.experimentId IN (:...experimentIds)', { experimentIds }) | ||
| .groupBy('ie.userId , ie.experimentId , ie.id') |
Comment on lines
435
to
438
| repeatedEnrollmentCounts = await this.repeatedEnrollmentRepository.getRepeatedEnrollmentCount( | ||
| userId, | ||
| allWithinSubjectDecisionPoints.map((dp) => dp.id), | ||
| filteredWithinSubjectExperiments.map((experiment) => experiment.id), | ||
| logger |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.