fix: resolve issues #95, #96, #97, #98 - #266
Merged
DeFiVC merged 1 commit intoJul 30, 2026
Merged
Conversation
|
@GF-Hunter Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
GF-Hunter
changed the title
GF-Hunter
force-pushed
the
fix/build-config-docker-env-e2e
branch
from
July 29, 2026 21:40
a0d2e4e to
8ef7aae
Compare
…al#96, ChainLearnOfficial#97, ChainLearnOfficial#98 - .env.example: create template so README setup instructions work - Dockerfile: copy drizzle config and migrations for prod migrations - E2E tests: remove 500 from allowed status codes so tests fail on errors - tsconfig.json: disable declaration/declarationMap for app builds
GF-Hunter
force-pushed
the
fix/build-config-docker-env-e2e
branch
from
July 29, 2026 21:48
8ef7aae to
7168344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues identified in
AGENTS.md— build config, test quality, Docker image completeness, and developer onboarding.Changes
#95 — Create
.env.examplefileCreates
.env.examplesocp .env.example .envworks as documented in README. Includes all required environment variables with placeholder values.Also adds
!.env.examplenegation to.gitignoreso the template file is tracked by Git.#96 — Dockerfile: copy drizzle config and migrations
drizzle.config.*from.dockerignoreso the file is available in the Docker build context.drizzle.config.tsandsrc/database/migrations/alongsidepackage.json, enablingdrizzle-kit migratein production containers.#97 — E2E tests: remove 500 from allowed status codes
Removed
500from expected status code arrays in all E2E tests. Tests that previously accepted[200, 500]now useexpect(response.statusCode).toBe(200). Others had500dropped from their allowed list. Tests will now fail when the server returns a 500 error.#98 — tsconfig.json: disable declaration files
declarationanddeclarationMapare already set tofalse. No change needed.Related Issues
Closes #95,
Closes #96,
Closes #97,
Closes #98