Skip to content

feat: Add opt-out uv installer for package-init.sh's Python packages#14

Merged
danny-avila merged 1 commit into
ClickHouse:mainfrom
gdrc-swastik:feature/uv-package-installer-toggle
Jul 22, 2026
Merged

feat: Add opt-out uv installer for package-init.sh's Python packages#14
danny-avila merged 1 commit into
ClickHouse:mainfrom
gdrc-swastik:feature/uv-package-installer-toggle

Conversation

@gdrc-swastik

@gdrc-swastik gdrc-swastik commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

pip's resolver takes noticeably longer than uv's on the Python package list (numpy/pandas/scipy/opencv/etc.), which matters for anyone rebuilding the packages PVC/Job in CI or a fresh local cluster.

On my dev machine (Mac), what took pip 20+ min was done by uv in <5min.

PYTHON_PACKAGE_INSTALLER defaults to "uv" and installs the same package list with uv instead (pinned via UV_VERSION, default 0.11.26). Setting it to "pip" preserves existing behavior exactly.

Verified locally (arm64 Docker): both paths complete the full Python + Node + Bun + Bash init successfully. As with any unpinned "latest compatible" install, resolved versions for unconstrained packages can differ between runs and installers - that's inherent to the existing unpinned package list, not introduced by this change.

pip's resolver takes noticeably longer than uv's on the Python package list
(numpy/pandas/scipy/opencv/etc.), which matters for anyone rebuilding the
packages PVC/Job in CI or a fresh local cluster. PYTHON_PACKAGE_INSTALLER
defaults to "uv" and installs the same package list with uv instead (pinned via
UV_VERSION, default 0.11.26). Setting it to "pip" preserves existing behavior exactly.

Verified locally (arm64 Docker): both paths complete the full
Python + Node + Bun + Bash init successfully. As with any unpinned "latest compatible"
install, resolved versions for unconstrained packages can differ between
runs and installers — that's inherent to the existing unpinned package list,
not introduced by this change.
@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: cd2e7c913d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila danny-avila changed the title Faster package-init: Add opt-out uv installer for package-init.sh's Python packages feat: Add opt-out uv installer for package-init.sh's Python packages Jul 22, 2026
@danny-avila danny-avila changed the title feat: Add opt-out uv installer for package-init.sh's Python packages feat: Add opt-out uv installer for package-init.sh's Python packages Jul 22, 2026
@danny-avila
danny-avila merged commit d8d1f4b into ClickHouse:main Jul 22, 2026
3 checks passed
@gdrc-swastik
gdrc-swastik deleted the feature/uv-package-installer-toggle branch July 22, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants