Conversation
evan-cz
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
PR #872 moved
prometheus-config-reloaderinto the agent image and removed thecomponents.prometheusReloader.imageandconfigmapReload.prometheus.imageoverride keys. The values schema is strict (additionalProperties: false), so existing values files that still set either key now fail validation onhelm upgrade.What
Restore both keys to the schema as deprecated, ignored tombstones (the forward-compat CP-43357 originally specified). They validate but have no effect — the in-image reloader is always used.
How Tested
make helm-lintand the schema test suite pass. Added two.passschema fixtures asserting both legacy keys validate.