Manchester | 26-ITP-Jan | Abdu Hassen | Sprint 3| Alarm Clock App - #1124
Manchester | 26-ITP-Jan | Abdu Hassen | Sprint 3| Alarm Clock App#1124Abduhasen wants to merge 3 commits into
Conversation
Abduhasen
added
📅 Sprint 3
Luro91
added
Review in progress
| @@ -1,4 +1,22 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
There was a problem hiding this comment.
What happens when the user sets an alarm when the countdown is already running?
| function setAlarm() {} | ||
| function setAlarm() { | ||
| const userInput = document.querySelector("#alarmSet").value; | ||
| let timeRemaining = userInput; |
There was a problem hiding this comment.
What happens when the user enters a negative number or a string value?
Luro91
added
Reviewed
Abduhasen
added
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
Well done.
A note on commit messages. It's hard to know for me what happens in a commit if the message is not descriptive. A commit should describe what changed in the code. It's also good practice to split commits into logical blocks (for example for each task or each review comment). This makes it easier to understand and additionally the commits could also be undone more easily if needed.
I like this article about commit messages: https://chris.beams.io/git-commit
Luro91
added
Complete
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
3 participants
Learners, PR Template
Self checklist
Changelist
-write and implement alarm clock
Questions
N/A