Skip to content

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3| Alarm Clock - #1128

Closed
Ayogit1 wants to merge 2 commits into
CodeYourFuture:mainfrom
Ayogit1:Alarm-clock
Closed

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3| Alarm Clock#1128
Ayogit1 wants to merge 2 commits into
CodeYourFuture:mainfrom
Ayogit1:Alarm-clock

Conversation

@Ayogit1

@Ayogit1 Ayogit1 commented Mar 28, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed alarm clock task

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 28, 2026
@magarpratik magarpratik added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 3, 2026

@magarpratik magarpratik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work! 🙌

The code is very easy to read and understand. I found the variable names quite descriptive and the code well structured.

I've just added a few comments highlighting minor points. Overall the PR looks very good! 👍

Comment thread Sprint-3/alarmclock/alarmclock.js Outdated
Comment thread Sprint-3/alarmclock/alarmclock.js
Comment thread Sprint-3/alarmclock/alarmclock.js
Comment thread Sprint-3/alarmclock/alarmclock.js
@magarpratik magarpratik added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 3, 2026
@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 12, 2026
@magarpratik magarpratik added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 12, 2026
@illicitonion

Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants