Glasgow | 26-ITP-May | Chan Yat Long | Sprint 3 | Quote generator - #1251
Open
Motorcycle-lab wants to merge 5 commits into
Open
Glasgow | 26-ITP-May | Chan Yat Long | Sprint 3 | Quote generator#1251Motorcycle-lab wants to merge 5 commits into
Motorcycle-lab wants to merge 5 commits into
Conversation
Motorcycle-lab
changed the title
Motorcycle-lab
added
Needs Review
Motorcycle-lab
changed the title
|
Code logic looks good, could you make use of a suggested tool to make the code more readable? |
| <div class="card"> | ||
| <div class="quote-container"> | ||
|
|
||
| <span class="quote-mark">“</span><p id="quote"></p> |
There was a problem hiding this comment.
Seems to have open quote-marks but can't see any closing
| // First condition: When a person click the button, it should generate back a quote; | ||
|
|
||
| function updateWebpageWithQuote() { | ||
| const elem = document.querySelector("#quote"); |
There was a problem hiding this comment.
Can you think of better names for your variables, which describe the intent?
madhuranakate
added
Reviewed
added 2 commits
July 30, 2026 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
clean commit for html, css and javascript
Questions
no