London | 26-ITP-May | Dipa Sarker | Sprint 2 | Sprint-2-exercises - #1272
Open
Dipa-Sarker wants to merge 12 commits into
Open
London | 26-ITP-May | Dipa Sarker | Sprint 2 | Sprint-2-exercises#1272Dipa-Sarker wants to merge 12 commits into
Dipa-Sarker wants to merge 12 commits into
Conversation
Dipa-Sarker
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks, there are a few you could improve
| const decodeKey = decodeURIComponent(key); | ||
| const decodeValue = decodeURIComponent(value); | ||
| const replacedKey = decodeKey.replace("+", " "); | ||
| const replacedValue = decodeValue.replace("+", " "); |
There was a problem hiding this comment.
what happens if you have a value like a+b+c+d?
Author
There was a problem hiding this comment.
Should I have to use replaceAll( ) instead of replace( ) for multiple "+" occurance?
There was a problem hiding this comment.
yes, replaceAll sounds like a good option here.Can you try implementing that?
LonMcGregor
removed
Needs Review
Dipa-Sarker
added
the
Needs Review
LonMcGregor
added
Reviewed
Dipa-Sarker
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed the Debug, Implement, and Interpret sections of the sprint.
Implemented the required functions and verified them with tests:
containslookuptallyquerystringChecked the functions with different inputs to ensure they behave according to the requirements.
**Testing