London | 26-ITP-May | Liridona Shehu | Sprint 2 | Module Data Groups - #1284
Open
shehu-dona wants to merge 18 commits into
Open
London | 26-ITP-May | Liridona Shehu | Sprint 2 | Module Data Groups#1284shehu-dona wants to merge 18 commits into
shehu-dona wants to merge 18 commits into
Conversation
shehu-dona
added
📅 Sprint 2
hey-hammad
added
Review in progress
hey-hammad
suggested changes
Jul 28, 2026
hey-hammad
left a comment
hey-hammad
left a comment
There was a problem hiding this comment.
Great effort overall, few changes required.
| @@ -1,3 +1,14 @@ | |||
| function tally() {} | |||
| function tally(items) { | |||
There was a problem hiding this comment.
what will happen if I pass the following input to the fn?
["apple", "banana", "apple", "orange", "banana", undefined]
Author
There was a problem hiding this comment.
It treated undefined as a key and we receive undefined:1. Added if condition to ignore undefined and null
| @@ -1 +1 @@ | |||
| function parseQueryString(queryString) { | |||
There was a problem hiding this comment.
What happens if I pass null value to this function?
| let value; | ||
|
|
||
| if (equalIndex === -1) { | ||
| key = pair.slice(0); |
There was a problem hiding this comment.
No need to slice here as we know for sure that key = pair.
|
|
||
| test("Given an empty object, should swap the keys and values in the object", () => {}); | ||
|
|
||
| test("Given an object, should swap the keys and values in the object", () => {}); |
hey-hammad
added
Reviewed
shehu-dona
added
the
Needs Review
hey-hammad
removed
Needs Review
hey-hammad
added
Review in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
A PR with exercises around objects and debugging