Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Todo List - #1288

Open
tomdu3 wants to merge 10 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/2-todo-list
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 3 | Todo List#1288
tomdu3 wants to merge 10 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-3/2-todo-list

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • added mandatory functionality deleteCompleted
  • added stretch 1 - deadlines
  • added stretch 2 - Show time remaining

@tomdu3 tomdu3 added 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Jul 24, 2026
@Joshuafolorunsho Joshuafolorunsho added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2026
Joshuafolorunsho
Joshuafolorunsho reviewed Jul 29, 2026
View reviewed changes

@Joshuafolorunsho Joshuafolorunsho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely UI.

Image

Joshuafolorunsho
Joshuafolorunsho reviewed Jul 29, 2026
View reviewed changes

@Joshuafolorunsho Joshuafolorunsho left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to note:

When I clicked on the datepicker I could select a date in the past.
It would be a much better UX if we disabled past dates.

Overall, the functionality works brilliantly.
Great done!

@tomdu3

tomdu3 commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Thanks Joshua. The only reason I haven't excluded past dates is the fact the app only uses temporary memory (no local storage or database) so you wouldn't be able to see if something overdue.

Joshuafolorunsho
Joshuafolorunsho reviewed Jul 29, 2026
View reviewed changes
Comment thread Sprint-3/todo-list/script.mjs Outdated
@Joshuafolorunsho Joshuafolorunsho added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Joshuafolorunsho Joshuafolorunsho Joshuafolorunsho left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 🏕 Priority Mandatory This work is expected 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @Joshuafolorunsho