London | 26-ITP-May | D D | Sprint 1 | Exercise - fix - #1290
London | 26-ITP-May | D D | Sprint 1 | Exercise - fix#1290Dagim-Daniel wants to merge 2 commits into
Conversation
Dagim-Daniel
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
There are more than files to be updated in the Sprint-1 folder.
| numbers.push(x); | ||
| } | ||
| } | ||
| if (numbers.length === 0 || list.length === 0) { |
| function calculateMedian(list) { | ||
| const numbers = []; | ||
| for (const x of list) { | ||
| if (typeof x === "number") { |
There was a problem hiding this comment.
If you would like to exclude also Infinity and NaN, consider using the built-in function Number.isFinite() instead.
There was a problem hiding this comment.
thank you, this makes it clean and easier
cjyuan
added
Reviewed
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
sorry, cjyuan, i don't get it, if you mean other tasks under implment and refactor, i creat a branch for them. |
cjyuan, this is from my Data groups course, the tasks are under sprint 1, may be i created diffrent branch for sprint 1 (exericise(fix) , implement and refactor), if there is any let me know. |
Dagim-Daniel
added
the
Needs Review
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
Dagim-Daniel
changed the title
2 participants
Learners, PR Template
Self checklist
Changelist
tasks under sprint 1 - fix is done