London | May-26 | Liridona Shehu | Sprint 3 | Module-Data-Groups- Qoute Generator - #1312
Open
shehu-dona wants to merge 4 commits into
Open
London | May-26 | Liridona Shehu | Sprint 3 | Module-Data-Groups- Qoute Generator#1312shehu-dona wants to merge 4 commits into
shehu-dona wants to merge 4 commits into
Conversation
shehu-dona
added
📅 Sprint 3
madhuranakate
suggested changes
Jul 29, 2026
| ]; | ||
|
|
||
| function updateUI(quoteObject) { | ||
| let quoteParagraph = document.getElementById("quote"); |
There was a problem hiding this comment.
Do these change everytime updateUI is called? Is it efficient to query them here?
Author
There was a problem hiding this comment.
Removed document.getElementById("") outside the function.
| } | ||
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
| let randomQuote = pickFromArray(quotes); |
There was a problem hiding this comment.
Can we apply the DRY principle (Don't repeat yourself) here?
| </head> | ||
| <body> | ||
| <h1>hello there</h1> | ||
| <h1>Hello there</h1> |
There was a problem hiding this comment.
Is this H1 needed?
Just a suggestion - Worth playing around with the html and css to alter the look, format the quote etc
Author
There was a problem hiding this comment.
Removed unnecessary heading.
Definitely I will do that, soon as i will finish with mandatory tasks :)
madhuranakate
added
Reviewed
Author
|
Hello @madhuranakate |
shehu-dona
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
A PR with a quote generator app