Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App - #1321
Open
TTiamiyu wants to merge 3 commits into
Open
Birmingham | 26-ITP-May | Toluwalase Tiamiyu | Sprint 3 | Alarmclock App#1321TTiamiyu wants to merge 3 commits into
TTiamiyu wants to merge 3 commits into
Conversation
…e immediate display update on button click
TTiamiyu
marked this pull request as ready for review
July 29, 2026 21:40
TTiamiyu
added
🏕 Priority Mandatory
Luro91
added
the
Review in progress
Luro91
reviewed
Jul 30, 2026
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
The title of the webpage should say Alarm clock app. It says Title here at the moment
|
|
||
| // If input is invalid or empty, default to 0 | ||
| if (isNaN(totalSeconds) || totalSeconds < 0) { | ||
| totalSeconds = 0; |
There was a problem hiding this comment.
I am not sure if the expected user behaviour for invalid inputs is to set the seconds to 0. What else could you do instead?
| clearInterval(timerInterval); | ||
| } | ||
| // Function to render the formatted time (MM:SS) to the DOM | ||
| function updateDisplay() { |
There was a problem hiding this comment.
Good job putting the code for formatting and setting the countdown into an own function. This makes it reusable and easier to change the formtting if needed
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist