Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Sprint-3/2-practice-tdd/count.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
function countChar(stringOfCharacters, findCharacter) {
return 5
let count = 0;
for (let i = 0; i < stringOfCharacters.length; i++) {
if (stringOfCharacters[i] === findCharacter) {
count++;
}
}
return count;
}

module.exports = countChar;
32 changes: 31 additions & 1 deletion Sprint-3/2-practice-tdd/count.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,45 @@ const countChar = require("./count");
// When the function is called with these inputs,
// Then it should correctly count occurrences of `char`.

test("should count multiple occurrences of a character", () => {
test("The function should return the number of times a character appears ", () => {
const str = "aaaaa";
const char = "a";
const count = countChar(str, char);
expect(count).toEqual(5);
});
test("The function should return the number of times a character appears", () => {
const str = "hello";
const char = "l";
const count = countChar(str, char);
expect(count).toEqual(2);
});
test("The function should return the number of times a character appears", () => {
const str = "speed";
const char = "e";
const count = countChar(str, char);
expect(count).toEqual(2);
});

// Scenario: No Occurrences
// Given the input string `str`,
// And a character `char` that does not exist within `str`.
// When the function is called with these inputs,
// Then it should return 0, indicating that no occurrences of `char` were found.
test("the function should return 0 when there are no appears of the character", () => {
const str = "kkkk";
const char = "l";
const count = countChar(str, char);
expect(count).toEqual(0);
});
test("the function should return 0 when there are no appears of the character", () => {
const str = "bbbb";
const char = "c";
const count = countChar(str, char);
expect(count).toEqual(0);
});
test("the function should return 0 when there are no appears of the character", () => {
const str = "mmmmmzmze";
const char = "d";
const count = countChar(str, char);
expect(count).toEqual(0);
});
16 changes: 15 additions & 1 deletion Sprint-3/2-practice-tdd/get-ordinal-number.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
function getOrdinalNumber(num) {
return "1st";
let numberValue = num;
let lastDigit = numberValue % 10;
let lastTwoDigit = numberValue % 100;
if (lastTwoDigit === 11 || lastTwoDigit === 12 || lastTwoDigit === 13) {
return String(numberValue) + "th";
}
if (lastDigit === 1) {
return String(numberValue) + "st";
}
if (lastDigit === 2) {
return String(numberValue) + "nd";
}
if (lastDigit === 3) {
return String(numberValue) + "rd";
} else return String(numberValue) + "th";
}

module.exports = getOrdinalNumber;
32 changes: 32 additions & 0 deletions Sprint-3/2-practice-tdd/get-ordinal-number.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,35 @@ test("should append 'st' for numbers ending with 1, except those ending with 11"
expect(getOrdinalNumber(21)).toEqual("21st");
expect(getOrdinalNumber(131)).toEqual("131st");
});
// Case 2: Numbers ending with 2 (but not 12)
// When the number ends with 2, except those ending with 12,
// Then the function should return a string by appending "nd" to the number.
test("should append 'nd' for numbers ending with 2, except those ending with 12", () => {
expect(getOrdinalNumber(2)).toEqual("2nd");
expect(getOrdinalNumber(22)).toEqual("22nd");
expect(getOrdinalNumber(52)).toEqual("52nd");
});
// Case 3: Numbers ending with 3 (but not 13)
// When the number ends with 3, except those ending with 13,
// Then the function should return a string by appending "rd" to the number.
test("should append 'rd' for numbers ending with 3, except those ending with 13", () => {
expect(getOrdinalNumber(3)).toEqual("3rd");
expect(getOrdinalNumber(33)).toEqual("33rd");
expect(getOrdinalNumber(133)).toEqual("133rd");
});
Comment thread
LonMcGregor marked this conversation as resolved.
//Case 4: Numbers ending with 11,12 and 13
// When the number ends with 11,12 and 13,
// Then the function should return a string by appending "th" to the number.
test("should append 'th' for numbers ending with 11,12 and 13", () => {
expect(getOrdinalNumber(1011)).toEqual("1011th");
expect(getOrdinalNumber(312)).toEqual("312th");
expect(getOrdinalNumber(113)).toEqual("113th");
});
//Case 5: Numbers 11,12 and 13
// When the number is 11,12 and 13,
// Then the function should return a string by appending "th" to the number.
test("should append 'th' for numbers ending with 11,12 and 13", () => {
expect(getOrdinalNumber(11)).toEqual("11th");
expect(getOrdinalNumber(12)).toEqual("12th");
expect(getOrdinalNumber(13)).toEqual("13th");
});
10 changes: 8 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,13 @@
function repeatStr() {
function repeatStr(str, num) {
let result = "";
// Your implementation of this function must *not* call String.prototype.repeat (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/repeat).
// The goal is to re-implement that function, not to use it.
return "hellohellohello";

if (num < 0) {
throw new Error();
}

return str.repeat(num);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you have another look at this task - check the comment at the start which mentions what you should avoid.

My original comment was about the if branches you had after your for loop, which was a good implementation. The if branches seemed like they might not be necessary. Can you try re-implementing just the for loop?

}

module.exports = repeatStr;
19 changes: 17 additions & 2 deletions Sprint-3/2-practice-tdd/repeat-str.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,28 @@ test("should repeat the string count times", () => {
// Given a target string `str` and a `count` equal to 1,
// When the repeatStr function is called with these inputs,
// Then it should return the original `str` without repetition.

test("should return the original string when count equal to 1", () => {
const str = "manchester";
const count = 1;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("manchester");
});
// Case: Handle count of 0:
// Given a target string `str` and a `count` equal to 0,
// When the repeatStr function is called with these inputs,
// Then it should return an empty string.

test("should return the empty string when count equal to 0", () => {
const str = "ahmed";
const count = 0;
const repeatedStr = repeatStr(str, count);
expect(repeatedStr).toEqual("");
});
// Case: Handle negative count:
// Given a target string `str` and a negative integer `count`,
// When the repeatStr function is called with these inputs,
// Then it should throw an error, as negative counts are not valid.
test("should throw an error when negative values pass to it", () => {
expect(() => {
repeatedStr("hi", -3);
}).toThrow();
});
Loading