London | 26- ITP-May | Edina Kurdi | Sprint 3 | Practice TDD - #1539
Open
edinakurdi wants to merge 6 commits into
Open
London | 26- ITP-May | Edina Kurdi | Sprint 3 | Practice TDD#1539edinakurdi wants to merge 6 commits into
edinakurdi wants to merge 6 commits into
Conversation
edinakurdi
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
edinakurdi
force-pushed
the
coursework/sprint-3-practice-tdd
branch
from
July 20, 2026 21:55
ed24e99 to
f7c1dd7
Compare
edinakurdi
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work on these tasks, I have a hint for an improvement
| function countChar(stringOfCharacters, findCharacter) { | ||
| return 5 | ||
| function countChar(str, char) { | ||
| const arrayOfChars = Array.from(str); |
There was a problem hiding this comment.
Do you need to convert to an array here?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed TDD exercises as the second part of Sprint-3