Glasgow | 26-ITP-May | Francesco Romano Monda | Sprint 3 | Complete Sprint 3 implement and rewrite tests coursework

[fromonda]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

• Implemented the getAngleType function.
• Added tests covering all angle types, boundary values, and invalid angles.
• Rewrote the getAngleType tests using Jest.
• Implemented the isProperFraction function.
• Added tests covering proper fractions, improper fractions, zero values, and boundary cases.
• Rewrote the isProperFraction tests using Jest.
• Implemented the getCardValue function.
• Added support for Ace, face cards, and number cards.
• Added validation for invalid card strings and error handling.
• Rewrote the getCardValue tests using Jest.

[LonMcGregor]

Very close to be complete, one test case left.

[LonMcGregor]

In maths, we consider than -1/2 is proper, but -5/2 is not proper (because 5 is bigger than 2). Can you take another look at this?

[fromonda]

I corrected the assertion for the negative numerator and denominator case. The mistake stemmed from overlooking that the definition of a proper fraction is based on the absolute values of the numerator and denominator.

[LonMcGregor]

Thanks for making the change to the test. But now, if you run the test, it fails. Did you also change the implementation as well?

[fromonda]

Thanks for making the change to the test. But now, if you run the test, it fails. Did you also change the implementation as well?

Sorry for my oversight. I have fixed the implementation now.

[LonMcGregor]

Your tests are correct now, but there still seems to be an implementation problem - did you remember to run npm test and see what output you get for the tests within Sprint-3/1-implement-and-rewrite-tests/?

[fromonda]

Your tests are correct now, but there still seems to be an implementation problem - did you remember to run npm test and see what output you get for the tests within Sprint-3/1-implement-and-rewrite-tests/?

The PCs I had been using over the past few days did not have Node.js installed, and I was not permitted to install it. Today, I was granted permission to install it, which allowed me to run the Node Package Manager and execute the tests.
After running the test suite, I updated the source code to address the implementation issue identified by the failing test. I hope the task can now be considered complete.

[LonMcGregor]

Yes, using Math.abs was the solution here. Task is complete now