London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | implement-and-rewrite - #1573
Open
ChinweP wants to merge 10 commits into
Open
London | 26-ITP-May | Chinwe Chukwuma | Sprint 3 | implement-and-rewrite#1573ChinweP wants to merge 10 commits into
ChinweP wants to merge 10 commits into
Conversation
…ithub.com/ChinweP/Module-Structuring-and-Testing-Data into coursework/sprint-3-implement-and-rewrite
ChinweP
added
Needs Review
cjyuan
added
the
Review in progress
cjyuan
reviewed
Jul 27, 2026
Comment on lines
+15
to
+18
| if (denominator <= 0) { | ||
| return false; | ||
| } | ||
| return numerator < denominator; |
Contributor
There was a problem hiding this comment.
What authoritative source do you base your definition of a proper fraction on?
Author
There was a problem hiding this comment.
Thank you @cjyuan for your feedback. I have added authoritative source and made necessary adjustments.
| }); | ||
|
|
||
| // Case 6: Invalid angles | ||
| test(`should return "Invalid angle" for angles outside valid range`, () => { |
Contributor
There was a problem hiding this comment.
Could consider indicate explicitly what the valid range is.
Author
There was a problem hiding this comment.
Hi @cjyuan, I've made the clarification. Thank you for your feedback.
cjyuan
added
Reviewed
ChinweP
added
the
Needs Review
cjyuan
reviewed
Jul 29, 2026
| }); | ||
|
|
||
| // Case 6: Invalid angles | ||
| test(`should return "Invalid angle" for angles outside valid range (1-359)`, () => { |
Contributor
There was a problem hiding this comment.
Could the value of angle be a decimal number? For example, is 0.5 a valid angle?
Comment on lines
+26
to
+28
| - The denominator is positive. | ||
|
|
||
| Source: https://www.mathsisfun.com/proper-fractions.html |
Contributor
There was a problem hiding this comment.
Note: The source does not actually say anything about negative numerator or denominator.
No change required because the spec also does not say anything about what to do with negative numbers.
cjyuan
removed
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed coursework/implement-and-rewrite following the ReadMe instruction.