fix(rendering): clear drawing infos instead of modifying and clearing together#2766
Merged
Merged
Conversation
Danielku15
force-pushed
the
hotfix/collection-modification
branch
from
d08512f to
7e9d434
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2748
Proposed changes
Fixes the concurrent modification of the
drawingInfoswhen clearing it the same time. Looks like this was some sort of merge conflict as the code didn't really make sense. Modifying the coordinates and then clearing the whole map doesn't make sense. Kept the clearing for 1.8.x, In 1.9.x the code is already removed and reworked.Checklist
Further details