Initialize Bootstrap appHash before reload checks#669
Closed
Copilot wants to merge 4 commits into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Fix appHash parameter initialization in reloadChecks
Initialize Bootstrap appHash before reload checks
Jun 26, 2026
lmajano
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap.reloadChecks()can run beforeloadColdBox()on first request or after a restart. In that path, the lock name referencedappHashbefore it had been initialized, which could fail bootstrap recovery when startup errors occurred.Bootstrap initialization
appHashinBootstrap.init()so it is available beforeloadColdBox()runs.appHashin the component-levelparamblock, since that can run before the application scope is available on first startup.Why this matters
reloadChecks()are always available, regardless of whether the framework has completed initialization.application.applicationnameaccess until bootstrap construction.Regression coverage
appHashbeing available immediately after bootstrap constructionreloadChecks()being callable beforeloadColdBox()has initialized the framework// Before function loadColdBox(){ // appHash was not yet available here on early reloadChecks() paths } function reloadChecks(){ lock name="#appHash#" ... } // After function init(){ variables.appHash = hash( getBaseTemplatePath() & application.applicationname ) } function reloadChecks(){ lock name="#appHash#" ... }