Modernize dependencies: update cffi to 2.0.0 and setuptools-golang to 2.9.0#53
Open
jainal09 wants to merge 3 commits into
Open
Modernize dependencies: update cffi to 2.0.0 and setuptools-golang to 2.9.0#53jainal09 wants to merge 3 commits into
jainal09 wants to merge 3 commits into
Conversation
… 2.9.0 - Update cffi from ~=1.1 to >=2.0.0 - Update setuptools-golang from 2.7.0 to 2.9.0 Tested with Python 3.14 and Go 1.25.4. All 14 tests pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates Python build/install dependencies to support newer ecosystem requirements (notably newer cryptography), by bumping cffi and setuptools-golang versions used during the build of the Go shared library and CFFI bindings.
Changes:
- Update the build-time
pip installstep to usecffi>=2.0.0. - Bump
setup_requiresfromsetuptools-golang==2.7.0to==2.9.0and updatecfficonstraints. - Update
install_requiresto requirecffi>=2.0.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Use sys.executable -m pip instead of bare pip to ensure correct interpreter - Use subprocess.check_call to fail on install errors - Add upper bound to cffi version (>=2.0.0,<3) to prevent future breakage Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
|
@ColdHeat please review |
Add bluemonday.c, bluemonday.h, and bluemonday.cpython-*.so to prevent accidentally committing generated files. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
~=1.1to>=2.0.02.7.0to2.9.0Why the need to upgrade?
When pybluemonday is used alongside the
cryptographypackage, it constrains users tocryptography<=44.0.3because pybluemonday requirescffi~=1.1(which means<2.0), while newer versions of cryptography requirecffi>=2.0.0.There is a high severity vulnerability (CVSS 8.2) affecting cryptography versions
<46.0.5. Without resolving the hard conflict withpybluemonday^0.0.14which constrainscffi~=1.1, users cannot upgrade to the patched cryptography version.This PR bumps the dependencies to their latest versions to unblock users from resolving this security issue.
Test plan
Tested with Python 3.14 and Go 1.25.4.
🤖 Generated with Claude Code