Skip to content

Account for LOGMSG, EXECPAUSE and EXECACK messages in parser#36

Merged
cpr-mab merged 1 commit into
CommonplaceRobotics:masterfrom
JuBiotech:issue-34
Jul 2, 2026
Merged

Account for LOGMSG, EXECPAUSE and EXECACK messages in parser#36
cpr-mab merged 1 commit into
CommonplaceRobotics:masterfrom
JuBiotech:issue-34

Conversation

@michaelosthege

Copy link
Copy Markdown
Contributor
  • LOGMSG are ignored, because every received message is logged already
  • EXECACK and EXECPAUSE are handled like EXECEND: One may subscribe the category, but detailed information and association with the command message is not available.

Closes #34


I noticed that EXECERROR → _parse_execerror results in a {"answer": "EXECEND", ... dict, leading to a potential conflict with EXECEND messages.
This is likely because the rest of the codebase only subscribes to EXECEND, never to EXECERROR.

I think one clean solution would be to include the command msg_id and aggregate not only one, but many responses per msg_id.

This would also account for the multiple EXECACK messages incoming during a multi-step program execution (if I understood that correctly).

Furthermore it would provide means to aggregate further details like cmdNr, progNr, programName in a sequence of typed response message objects.

In another project I use a similar pattern with MQTT communication, where every command has a "conversation_id" that's included in all response messages of different types.

@cpr-mab cpr-mab merged commit 96b6a2c into CommonplaceRobotics:master Jul 2, 2026
5 checks passed
@michaelosthege michaelosthege deleted the issue-34 branch July 2, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Protocol parser encountering unknown message types

2 participants