Account for LOGMSG, EXECPAUSE and EXECACK messages in parser#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LOGMSGare ignored, because every received message is logged alreadyEXECACKandEXECPAUSEare handled likeEXECEND: One may subscribe the category, but detailed information and association with the command message is not available.Closes #34
I noticed that
EXECERROR → _parse_execerrorresults in a{"answer": "EXECEND", ...dict, leading to a potential conflict withEXECENDmessages.This is likely because the rest of the codebase only subscribes to
EXECEND, never toEXECERROR.I think one clean solution would be to include the command
msg_idand aggregate not only one, but many responses permsg_id.This would also account for the multiple
EXECACKmessages incoming during a multi-step program execution (if I understood that correctly).Furthermore it would provide means to aggregate further details like
cmdNr, progNr, programNamein a sequence of typed response message objects.In another project I use a similar pattern with MQTT communication, where every command has a "conversation_id" that's included in all response messages of different types.