Skip to content

fix(opencode): log central fallback scope reasons#491

Merged
seonghobae merged 1 commit into
mainfrom
codex/opencode-fallback-scope-reasons
Jul 12, 2026
Merged

fix(opencode): log central fallback scope reasons#491
seonghobae merged 1 commit into
mainfrom
codex/opencode-fallback-scope-reasons

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • allow central OpenCode fallback scope to include the externalized CI/reviewer prompt files
  • emit explicit fallback ineligibility reasons in the Required OpenCode Review logs
  • guard the prompt allowlist and reason logging with the existing workflow contract test

Verification

  • py -3.12 -m pytest tests/test_opencode_agent_contract.py::test_workflow_provisions_sandbox_tool_and_reviewer_agent -q
  • git diff --check
  • codegraph init -i; codegraph sync; codegraph status

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 35bdfc4c573196dd2d08d38361d3a909837b7f21.

  • Head SHA: 35bdfc4c573196dd2d08d38361d3a909837b7f21

  • Workflow run: 29200098387

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: opencode-review.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V1["actionlint plus required checks"]
  Evidence --> S2["Test: test_opencode_agent_contract.py"]
  S2 --> I2["regression suite"]
  I2 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V2["targeted test run"]
Loading

@github-actions

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 35bdfc4c573196dd2d08d38361d3a909837b7f21
  • Workflow run: 29200098387
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 35bdfc4c573196dd2d08d38361d3a909837b7f21.

  • Head SHA: 35bdfc4c573196dd2d08d38361d3a909837b7f21

  • Workflow run: 29200098387

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: opencode-review.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V1["actionlint plus required checks"]
  Evidence --> S2["Test: test_opencode_agent_contract.py"]
  S2 --> I2["regression suite"]
  I2 --> Conflict["Merge conflict blocks this path"]
  Conflict --> V2["targeted test run"]
Loading

Merge Conflict Guidance

  • Current merge state: DIRTY
  • Base branch: main
  • Head branch: codex/opencode-fallback-scope-reasons
  • Fix direction: merge or rebase origin/main into codex/opencode-fallback-scope-reasons, resolve conflict markers in the changed files, rerun the focused checks, then push the same branch.
  • Repair commands:
gh pr checkout 491 --repo ContextualWisdomLab/.github
git fetch origin main
git merge --no-ff origin/main  # or: git rebase origin/main
git status --short
# resolve files, then git add <resolved-files>
# merge path: git commit
# rebase path: git rebase --continue
git push origin HEAD:codex/opencode-fallback-scope-reasons
# rebase path only: git push --force-with-lease origin HEAD:codex/opencode-fallback-scope-reasons

@seonghobae seonghobae force-pushed the codex/opencode-fallback-scope-reasons branch from 35bdfc4 to b8bc92a Compare July 12, 2026 16:27
@seonghobae seonghobae force-pushed the codex/opencode-fallback-scope-reasons branch from b8bc92a to a1c1dde Compare July 12, 2026 16:35
@seonghobae seonghobae dismissed github-actions[bot]’s stale review July 12, 2026 16:42

Stale automated request-changes review on old head 35bdfc4; current head a1c1dde has no unresolved review threads and checks are re-running.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: central OpenCode/Strix review-process
  • Changed files: 2
  • Model-pool outcome: exhausted
  • Head SHA: a1c1dded236e19406541206d7f5c381aeec5495e
  • Workflow run: 29200400627
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae enabled auto-merge (squash) July 12, 2026 16:58

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: central OpenCode/Strix review-process
  • Changed files: 2
  • Model-pool outcome: exhausted
  • Head SHA: a1c1dded236e19406541206d7f5c381aeec5495e
  • Workflow run: 29200400627
  • Workflow attempt: 2

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae merged commit b81259c into main Jul 12, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant