fix(opencode): JavaScript coverage flag 중복 방지#492
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.
Findings
No blocking findings.
Evidence
- Result: APPROVE
- Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
- Scope:
central OpenCode/Strix review-process - Changed files:
2 - Model-pool outcome:
exhausted - Head SHA:
527ed63c6abc581bd154a0f31accffa12988f0f5 - Workflow run: 29201544649
- Workflow attempt: 1
This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
중앙 Required OpenCode Review의 coverage-evidence가 이미 coverage를 포함한 저장소 test 스크립트에도
--coverage를 다시 전달했습니다. 실제bandscope #616, run29200268192, attempt 2에서npm test -- --coverage가vitest run --coverage --coverage로 확장되어Expected a single value for option --coverage로 실패했습니다.수정
--coverage,c8,nyc가 이미 있으면 runner의 기본 test 명령을 한 번만 실행합니다.검증
364 passedactionlint -shellcheck= .github/workflows/opencode-review.yml: 통과이 수정은 저장소별 우회 없이 중앙 coverage 증거 수집을 멱등적으로 만듭니다.