Skip to content

fix(opencode): JavaScript coverage flag 중복 방지#492

Merged
seonghobae merged 2 commits into
mainfrom
codex/opencode-js-coverage-idempotent
Jul 12, 2026
Merged

fix(opencode): JavaScript coverage flag 중복 방지#492
seonghobae merged 2 commits into
mainfrom
codex/opencode-js-coverage-idempotent

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

문제

중앙 Required OpenCode Review의 coverage-evidence가 이미 coverage를 포함한 저장소 test 스크립트에도 --coverage를 다시 전달했습니다. 실제 bandscope #616, run 29200268192, attempt 2에서 npm test -- --coveragevitest run --coverage --coverage로 확장되어 Expected a single value for option --coverage로 실패했습니다.

수정

  • package test 스크립트에 --coverage, c8, nyc가 이미 있으면 runner의 기본 test 명령을 한 번만 실행합니다.
  • coverage 설정이 없는 test 스크립트에는 기존처럼 runner별 coverage 인수를 추가합니다.
  • 두 경로를 모두 고정하는 중앙 회귀 테스트를 추가했습니다.

검증

  • 신규 회귀 테스트: 수정 전 실패, 수정 후 통과
  • 전체 중앙 테스트: 364 passed
  • actionlint -shellcheck= .github/workflows/opencode-review.yml: 통과
  • Trivy CRITICAL/HIGH/MEDIUM vuln/misconfig/secret: 0

이 수정은 저장소별 우회 없이 중앙 coverage 증거 수집을 멱등적으로 만듭니다.

@seonghobae seonghobae enabled auto-merge (squash) July 12, 2026 17:07

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: central OpenCode/Strix review-process
  • Changed files: 2
  • Model-pool outcome: exhausted
  • Head SHA: 527ed63c6abc581bd154a0f31accffa12988f0f5
  • Workflow run: 29201544649
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae merged commit e24e94a into main Jul 12, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant