Skip to content

fix(opencode): pnpm coverage 인자 전달 수정#494

Merged
seonghobae merged 1 commit into
mainfrom
fix/pnpm-coverage-forwarding
Jul 12, 2026
Merged

fix(opencode): pnpm coverage 인자 전달 수정#494
seonghobae merged 1 commit into
mainfrom
fix/pnpm-coverage-forwarding

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

문제

중앙 OpenCode coverage가 pnpm 저장소에서 pnpm test -- --coverage를 실행해 실제 스크립트를 vitest run -- --coverage로 만들었습니다. pg-erd-cloud #538에서는 126개 테스트가 모두 통과했지만 Vitest coverage가 활성화되지 않아 summary 파일이 없다는 명시적 실패가 발생했습니다.

수정

  • pnpm 경로를 pnpm run test --coverage로 전달해 스크립트 인자로 직접 전달
  • pnpm test --coverage 역시 pnpm 자체 옵션 오류가 나는 것을 로컬에서 재현하고 배제
  • npm과 yarn의 기존 동작 및 이미 coverage를 포함한 스크립트 감지는 유지
  • 잘못된 pnpm test -- --coverage와 pnpm test --coverage가 다시 들어오지 못하도록 contract assertion 추가

검증

  • TDD red: 새 contract assertion이 기존 잘못된 명령 때문에 실패
  • pg-erd-cloud #538: pnpm run test --coverage로 20 files, 126 tests 통과 및 V8 coverage summary 생성
  • focused test: 1 passed
  • 전체 pytest: 366 passed
  • actionlint: 통과
  • Trivy Medium/High/Critical vuln, misconfig, secret: 0건

병합 후 pg-erd-cloud #538을 닫았다 다시 열어 동일 HEAD에서 새 중앙 required workflow를 생성하고 coverage summary를 확인하겠습니다.

@seonghobae seonghobae enabled auto-merge (squash) July 12, 2026 17:38
@seonghobae seonghobae force-pushed the fix/pnpm-coverage-forwarding branch from eada5e5 to b54777c Compare July 12, 2026 17:41

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode model providers were unavailable for this same-head run, but deterministic current-head evidence is clean: coverage evidence passed, peer GitHub Checks are complete, medium-or-higher code-scanning alerts are clear, mergeability is clean, and reviewer threads are resolved or outdated.

Findings

No blocking findings.

Evidence

  • Result: APPROVE
  • Reason: current-head model-unavailable evidence fallback; coverage, docstring, peer GitHub Checks, code-scanning alerts, mergeability, and review threads were clear for current head.
  • Scope: central OpenCode/Strix review-process
  • Changed files: 2
  • Model-pool outcome: exhausted
  • Head SHA: b54777c731b64e2b21fe8e9c2b14acb21fc085a4
  • Workflow run: 29202473681
  • Workflow attempt: 1

This fallback does not suppress failed checks, medium-or-higher code-scanning alerts, merge conflicts, unresolved reviewer threads, or failed coverage evidence; any of those conditions still publish REQUEST_CHANGES or leave the approval state unchanged.

@seonghobae seonghobae merged commit 6ede60f into main Jul 12, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant