π‘οΈ Sentinel: [CRITICAL] νΈμ€νΈ ν€λ μΈμ μ μ·¨μ½μ μμ #218
π‘οΈ Sentinel: [CRITICAL] νΈμ€νΈ ν€λ μΈμ μ
μ·¨μ½μ μμ #218seonghobae wants to merge 1 commit into
Conversation
- `packages/web/src/app/api/admin/password-reset-links/route.ts` λ° `packages/web/src/app/api/auth/cli-request/route.ts`μμ νΈμ€νΈ ν€λ μΈμ μ μ μ·¨μ½ν `req.nextUrl.origin` μ¬μ©μ μ κ±°ν¨ - λμ κ²μ¦λ νκ²½λ³μμΈ `process.env.NEXT_PUBLIC_SITE_URL`λ₯Ό μ¬μ©νκ³ , λ체κ°μΌλ‘ 'https://argos-ai.xyz'λ₯Ό μ μ©ν¨ - `packages/web/next.config.ts` νμΌμ μ€λ³΅λ `headers()` λΈλ‘μ μ 리νκ³ λ³΄μ μ μ± (Permissions-Policy)μ ν΅ν©ν¨ - `.jules/sentinel.md` μ ν΄λΉ μ·¨μ½μ κ³Ό νμ΅ λ΄μ©μ νκ΅μ΄λ‘ κΈ°λ‘ν¨
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: API κ²½λ‘ λ΄λΆμμ ν΄λΌμ΄μΈνΈκ° μ‘°μ κ°λ₯ν νΈμ€νΈ ν€λλ₯Ό λ°νμΌλ‘ μ λ κ²½λ‘(
req.nextUrl.origin)λ₯Ό μμ±νμ¬, λΉλ°λ²νΈ μ¬μ€μ λ§ν¬ λ° μΈμ¦ μ½λ°± κ³Όμ μμ λ°μν μ μλ νΈμ€νΈ ν€λ μΈμ μ (Host Header Injection) μ·¨μ½μ μ λ°κ²¬νμμ΅λλ€.π― Impact: 곡격μκ° μ μμ μΌλ‘ νΈμ€νΈ ν€λλ₯Ό λ³μ‘°νλ©΄, μ¬μ©μκ° κ³΅κ²©μμ μλ²λ‘ 리λ€μ΄λ νΈλμ΄ μΈμ¦ μ λ³΄κ° νμ·¨λκ±°λ νΌμ± 곡격μ λμμ΄ λ μ μμ΅λλ€.
π§ Fix:
req.nextUrl.originμ μ¬μ©μ μ κ±°νκ³ , μ λ’°ν μ μλ νκ²½ λ³μ(process.env.NEXT_PUBLIC_SITE_URL)λ₯Ό μ°Έμ‘°νλλ‘ λ³κ²½νμμ΅λλ€. λν,next.config.tsνμΌμ μ€λ³΅μΌλ‘ μ‘΄μ¬νλheaders()ν¨μλ₯Ό νλλ‘ ν΅ν©νμ¬ λΆνμν μ€λ₯λ₯Ό μμ νμμ΅λλ€.β Verification:
pnpm testκ° ν΅κ³ΌνμμΌλ©°,pnpm buildκ³Όμ μμ μλ¬κ° λ°μνμ§ μμμ νμΈνμμ΅λλ€.PR created automatically by Jules for task 2582016819372837864 started by @seonghobae