Skip to content

🎨 Palette: [UX improvement] μ„Έμ…˜ 파일 λͺ©λ‘ ν‚€λ³΄λ“œ μ ‘κ·Όμ„± ν–₯상 및 슀크린 리더 κ²½ν—˜ κ°œμ„ #224

Open
seonghobae wants to merge 4 commits into
developmentalfrom
palette-a11y-session-files-752419032894513525
Open

🎨 Palette: [UX improvement] μ„Έμ…˜ 파일 λͺ©λ‘ ν‚€λ³΄λ“œ μ ‘κ·Όμ„± ν–₯상 및 슀크린 리더 κ²½ν—˜ κ°œμ„ #224
seonghobae wants to merge 4 commits into
developmentalfrom
palette-a11y-session-files-752419032894513525

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What (무엇을 λ³€κ²½ν–ˆλ‚˜μš”?)

  • packages/web/src/components/dashboard/session-files.tsx 파일의 μ»€μŠ€ν…€ λ²„νŠΌλ“€μ— ν‚€λ³΄λ“œ 포컀슀 μƒνƒœ(focus-visible)λ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • 슀크린 λ¦¬λ”μ—μ„œ μž₯μ‹μš© μ•„μ΄μ½˜λ“€μ„ λΆˆν•„μš”ν•˜κ²Œ 읽지 μ•Šλ„λ‘ aria-hidden="true" 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why (μ™œ λ³€κ²½ν–ˆλ‚˜μš”?)

  • 기쑴의 파일 λͺ©λ‘ 및 μ„œλ¨Έλ¦¬ λ²„νŠΌλ“€μ€ ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ μ‹œ 포컀슀 μƒνƒœκ°€ λͺ…ν™•ν•˜κ²Œ 보이지 μ•Šμ•„ 접근성이 λ–¨μ–΄μ‘ŒμŠ΅λ‹ˆλ‹€. focus-visible 클래슀λ₯Ό ν™œμš©ν•΄ 마우슀 μ‚¬μš©μžμ—κ²ŒλŠ” 영ν–₯을 μ£Όμ§€ μ•ŠμœΌλ©΄μ„œ ν‚€λ³΄λ“œ μ‚¬μš©μžμ—κ²Œ λͺ…ν™•ν•œ ν”Όλ“œλ°±μ„ μ œκ³΅ν•©λ‹ˆλ‹€.
  • <Pencil />, <Eye />, <FileText /> 와 같은 μ•„μ΄μ½˜λ“€μ€ ν…μŠ€νŠΈ 라벨과 ν•¨κ»˜ μ‚¬μš©λ˜λ―€λ‘œ, 슀크린 리더가 이듀을 μ€‘λ³΅μœΌλ‘œ 읽지 μ•Šλ„λ‘ ν•˜μ—¬ λ…Έμ΄μ¦ˆλ₯Ό μ€„μ˜€μŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

  • ν‚€λ³΄λ“œμ˜ Tab ν‚€λ‘œ 이동 μ‹œ, "modified" 및 "read" μš”μ•½ λ²„νŠΌκ³Ό 파일 λͺ©λ‘μ˜ 각 μ•„μ΄ν…œμ— λͺ…ν™•ν•œ 아웃라인 링(ring-2)이 ν‘œμ‹œλ©λ‹ˆλ‹€.

β™Ώ Accessibility

  • focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring (λ˜λŠ” ring-success) 적용으둜 ν‚€λ³΄λ“œ 포컀슀 κ°€μ‹œμ„± 확보.
  • μž₯μ‹μš© μ•„μ΄μ½˜μ— aria-hidden="true" μΆ”κ°€ν•˜μ—¬ λΆˆν•„μš”ν•œ 슀크린 리더 λ…Έμ΄μ¦ˆ 제거.

PR created automatically by Jules for task 752419032894513525 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant