๐จ Palette: [UX improvement] Enhance ContextSection accessibility#243
๐จ Palette: [UX improvement] Enhance ContextSection accessibility#243seonghobae wants to merge 5 commits into
Conversation
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
โฆ3474212620094974
โฆ3474212620094974
โฆ3474212620094974
๐ก What
ContextSection์ปดํฌ๋ํธ์ ํ ๊ธ ๋ฒํผ์ ๋ช ํํ ํค๋ณด๋ ํฌ์ปค์ค ์คํ์ผ(focus-visible)์ ์ถ๊ฐํ์ต๋๋ค.useId()ํ ์ ์ฌ์ฉํ์ฌ ๋ฒํผ๊ณผ ์ฝํ ์ธ ์์ญ ๊ฐ์aria-controls๋ฐid์ฐ๊ฒฐ์ ๋์ ์ผ๋ก ์์ฑํ์ต๋๋ค.๐ฏ Why
ContextSection์ด ์กด์ฌํ ๋ ํ๋์ฝ๋ฉ๋ ID๋ก ์ธํด ๋ฐ์ํ ์ ์๋ ์ถฉ๋์ ๋ฐฉ์งํ๊ณ , ์คํฌ๋ฆฐ ๋ฆฌ๋๊ฐ ๋ฒํผ๊ณผ ์จ๊ฒจ์ง ์ฝํ ์ธ ๊ฐ์ ๋ ผ๋ฆฌ์ ์ฐ๊ฒฐ์ ์ ํํ ํ์ ํ ์ ์๋๋ก ๊ฐ์ ํ์ต๋๋ค.๐ธ Before/After
ring-2)์ด ์ ์ฉ๋จ์ ํ์ธ ์๋ฃํ์ต๋๋ค.โฟ Accessibility
aria-controls๋ฐ ๊ณ ์id๋ถ์ฌ (์คํฌ๋ฆฐ ๋ฆฌ๋ ๋ค๋น๊ฒ์ด์ ํฅ์)focus-visible:ring-2๋ฑ ์ ํธ๋ฆฌํฐ ํด๋์ค ์ถ๊ฐ (ํค๋ณด๋ ๋ค๋น๊ฒ์ด์ ์์ธ์ฑ ํฅ์)PR created automatically by Jules for task 7873474212620094974 started by @seonghobae