Skip to content

🎨 Palette: [UX improvement] Context Section μ»΄ν¬λ„ŒνŠΈ μ ‘κ·Όμ„± κ°œμ„ #244

Open
seonghobae wants to merge 3 commits into
developmentalfrom
palette-context-section-a11y-7948769173390846838
Open

🎨 Palette: [UX improvement] Context Section μ»΄ν¬λ„ŒνŠΈ μ ‘κ·Όμ„± κ°œμ„ #244
seonghobae wants to merge 3 commits into
developmentalfrom
palette-context-section-a11y-7948769173390846838

Conversation

@seonghobae

Copy link
Copy Markdown

πŸ’‘ What

ContextSection μ»΄ν¬λ„ŒνŠΈ λ‚΄μ˜ μ•„μ½”λ””μ–Έ ν† κΈ€ λ²„νŠΌμ— ν‚€λ³΄λ“œ 탐색 포컀슀 μŠ€νƒ€μΌ(focus-visible)을 μΆ”κ°€ν•˜κ³ , 슀크린 리더 μ‚¬μš©μžλ₯Ό μœ„ν•΄ WAI-ARIA 속성(aria-controls, aria-labelledby, role="region")을 μ˜¬λ°”λ₯΄κ²Œ λ§€ν•‘ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

κΈ°μ‘΄ ContextSection μ»΄ν¬λ„ŒνŠΈλŠ” 마우슀 μ ‘κ·Όμ—λŠ” λ¬Έμ œκ°€ μ—†μ—ˆμœΌλ‚˜, νƒ­ ν‚€λ₯Ό ν†΅ν•œ ν‚€λ³΄λ“œ 탐색 μ‹œ 포컀슀 링이 ν‘œμ‹œλ˜μ§€ μ•Šμ•„ μ–΄λŠ μš”μ†Œμ— μœ„μΉ˜ν•΄ μžˆλŠ”μ§€ μ‹œκ°μ μΈ ν”Όλ“œλ°±μ΄ λΆ€μ‘±ν–ˆμŠ΅λ‹ˆλ‹€. λ˜ν•œ 슀크린 리더 μ‚¬μš©μžμ—κ²Œ ν† κΈ€ λ²„νŠΌκ³Ό νŽΌμ³μ§€λŠ” λ‚΄μš© μ‚¬μ΄μ˜ 연관성을 의미적으둜 μ œκ³΅ν•˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

(Playwright μ˜μƒ/μŠ€ν¬λ¦°μƒ· 검증 μ™„λ£Œ)

  • Before: νƒ­ ν‚€ 포컀슀 μ‹œ μ™Έκ³½μ„  μ—†μŒ, 컨텐츠 μ˜μ—­μ— ID 및 aria-labelledby 속성 λΆ€μž¬
  • After: νƒ­ ν‚€ 포컀슀 μ‹œ λͺ…ν™•ν•œ 포컀슀 링 ν‘œμ‹œ(ring-2 ring-ring), ν† κΈ€ λ²„νŠΌκ³Ό νŒ¨λ„ 컨텐츠가 고유 IDλ₯Ό 톡해 ARIA μ†μ„±μœΌλ‘œ 연결됨

β™Ώ Accessibility

  • useId 훅을 λ„μž…ν•˜μ—¬ κ³ μœ ν•œ IDλ₯Ό λΆ€μ—¬ν•¨μœΌλ‘œμ¨, ν•œ νŽ˜μ΄μ§€μ— μ—¬λŸ¬ ContextSection이 μ‚¬μš©λ˜λ”λΌλ„ 슀크린 리더가 λ²„νŠΌκ³Ό ν•΄λ‹Ή λ‚΄μš© μ˜μ—­μ„ μ •ν™•ν•˜κ²Œ λ§€ν•‘(aria-controls, aria-labelledby)ν•  수 있게 λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • νŒ¨λ„μ„ κ°μ‹ΈλŠ” div μš”μ†Œμ— role="region"을 ν• λ‹Ήν•˜μ—¬ 슀크린 리더가 λͺ…ν™•ν•œ μ˜μ—­ λžœλ“œλ§ˆν¬λ‘œ μΈμ‹ν•˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν™”μ‚΄ν‘œ(Chevron) μ•„μ΄μ½˜ λ“± μ‹œκ°μ μΈ μž₯식 μš”μ†ŒλŠ” aria-hidden="true" 속성을 μΆ”κ°€ν•˜μ—¬ 슀크린 리더가 λΆˆν•„μš”ν•˜κ²Œ 읽지 μ•Šλ„λ‘ μ‘°μΉ˜ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν‚€λ³΄λ“œ 포컀슀(focus-visible:ring-2) 지원을 μΆ”κ°€ν•˜μ—¬ μ‹œκ°μ  접근성을 κ°•ν™”ν–ˆμŠ΅λ‹ˆλ‹€.

PR created automatically by Jules for task 7948769173390846838 started by @seonghobae

- Add `useId()` to dynamically generate ARIA relation IDs
- Link button and region with `aria-controls`, `id`, and `aria-labelledby`
- Hide chevron icons from screen readers using `aria-hidden="true"`
- Add `focus-visible` classes to button to display focus rings for keyboard navigation
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant