Skip to content

🎨 Palette: [UX improvement] Fix ARIA button nesting and add global aria-disabled button styling#632

Closed
seonghobae wants to merge 2 commits into
developfrom
palette/fix-aria-button-nesting-3231131146197921453
Closed

🎨 Palette: [UX improvement] Fix ARIA button nesting and add global aria-disabled button styling#632
seonghobae wants to merge 2 commits into
developfrom
palette/fix-aria-button-nesting-3231131146197921453

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: apps/desktop/src/App.tsx의 "Save Project" λΉ„ν™œμ„±ν™” λ²„νŠΌμ„ 감싸고 있던 <span role="button"> 래퍼λ₯Ό μ œκ±°ν•˜κ³ , λ„€μ΄ν‹°λΈŒ disabled 속성을 μ‚¬μš©ν•˜μ§€ μ•ŠμœΌλ©΄μ„œ 툴팁 접근성을 보μž₯ν•˜κΈ° μœ„ν•΄ μ „μ—­ <Button> μ»΄ν¬λ„ŒνŠΈ(apps/desktop/src/components/ui/button.tsx)에 aria-disabled μŠ€νƒ€μΌλ§μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: μƒν˜Έμž‘μš© κ°€λŠ₯ν•œ μš”μ†Œ(role="button") 내뢀에 또 λ‹€λ₯Έ λ„€μ΄ν‹°λΈŒ <button> μš”μ†Œκ°€ ν¬ν•¨λ˜λ©΄ 슀크린 λ¦¬λ”μ—μ„œ 쀑볡/ν˜Όλž€μŠ€λŸ¬μš΄ 트리λ₯Ό μƒμ„±ν•˜μ—¬ ARIA μŠ€νŽ™μ„ μœ„λ°˜ν•˜κ²Œ λ©λ‹ˆλ‹€. λ„€μ΄ν‹°λΈŒ disabled 속성 μ—­μ‹œ νƒ­ μˆœμ„œ(tab order)μ—μ„œ μš”μ†Œλ₯Ό μ œμ™Έμ‹œν‚€λ―€λ‘œ, ν˜Έλ²„ μ‹œ μ ‘κ·Ό κ°€λŠ₯ν•œ νˆ΄νŒμ„ μ œκ³΅ν•˜κΈ° μ–΄λ ΅μŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: μ‹œκ°μ  λ³€κ²½ 사항은 μ—†μœΌλ©°, 이전과 λ™μΌν•˜κ²Œ 50% 투λͺ…도 및 cursor-not-allowed μŠ€νƒ€μΌμ΄ μœ μ§€λ©λ‹ˆλ‹€.
β™Ώ Accessibility: 이제 λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ— ν‚€λ³΄λ“œ μ΄ˆμ μ„ 맞좜 수 있으며 슀크린 λ¦¬λ”λ‘œ μ˜¬λ°”λ₯΄κ²Œ 읽을 수 μžˆμŠ΅λ‹ˆλ‹€. 잘λͺ» μ€‘μ²©λœ ARIA λž˜νΌκ°€ μ œκ±°λ˜μ–΄ μ ‘κ·Όμ„± νŠΈλ¦¬κ°€ 훨씬 λͺ…ν™•ν•΄μ‘ŒμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 3231131146197921453 started by @seonghobae

…ia-disabled button styling

- λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ˜ 툴팁 접근성을 μœ μ§€ν•˜κΈ° μœ„ν•΄ μ‚¬μš©λ˜λ˜ `role="button"` span 래퍼λ₯Ό μ œκ±°ν•˜μ—¬ ARIA μŠ€νŽ™ μœ„λ°˜μ„ ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.
- `apps/desktop/src/App.tsx`의 "Save Project" λ²„νŠΌμ— `aria-disabled="true"`와 `tabIndex={0}`λ₯Ό 직접 μ μš©ν–ˆμŠ΅λ‹ˆλ‹€.
- `apps/desktop/src/components/ui/button.tsx`의 λͺ¨λ“  λ²„νŠΌ variant에 `aria-disabled` μƒνƒœμ— λŒ€ν•œ μŠ€νƒ€μΌλ§(opacity, cursor λ“±)을 μΆ”κ°€ν•˜μ—¬ μ „μ—­ μ ‘κ·Όμ„± 지원을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
- λ³€κ²½λœ DOM ꡬ쑰에 맞게 κ΄€λ ¨ Vitestλ₯Ό μ—…λ°μ΄νŠΈν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Superseded by #634. The canonical PR now keeps the existing .Jules palette log, removes the lower-case .jules case-collision, uses the shared unavailable-action handler, and covers the disabled Save Project defaultPrevented behavior.

@seonghobae seonghobae closed this Jul 12, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #634. The canonical PR now keeps the existing .Jules palette log, removes the lower-case .jules case-collision, uses the shared unavailable-action handler, and covers the disabled Save Project defaultPrevented behavior.

ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. 이 μž‘μ—…μ΄ λ‹€λ₯Έ PR둜 λŒ€μ²΄λ˜μ—ˆμœΌλ―€λ‘œ μž‘μ—…μ„ μ€‘λ‹¨ν•˜κ² μŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant