Skip to content

🎨 Palette: [UX improvement] ν”„λ‘œμ νŠΈ μ €μž₯ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ #636

Open
seonghobae wants to merge 2 commits into
developfrom
palette-ux-save-button-tooltip-16420223422450782798
Open

🎨 Palette: [UX improvement] ν”„λ‘œμ νŠΈ μ €μž₯ λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„ #636
seonghobae wants to merge 2 commits into
developfrom
palette-ux-save-button-tooltip-16420223422450782798

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: λΉ„ν™œμ„±ν™”λœ "ν”„λ‘œμ νŠΈ μ €μž₯" λ²„νŠΌμ˜ 툴팁 μ ‘κ·Όμ„± κ°œμ„  및 λΆˆν•„μš”ν•œ DOM 래퍼 제거
🎯 Why: λ„€μ΄ν‹°λΈŒ <button disabled>λ₯Ό 툴팁용 span으둜 κ°μ‹ΈλŠ” 방식은 ARIA 사양 μœ„λ°˜μ˜ μ†Œμ§€κ°€ 있으며, μ½”λ“œλ₯Ό λ³΅μž‘ν•˜κ²Œ λ§Œλ“­λ‹ˆλ‹€. aria-disabled="true"λ₯Ό 직접 λ²„νŠΌμ— μ‚¬μš©ν•˜λ©΄ 포컀슀 이동을 ν—ˆμš©ν•˜λ©΄μ„œ μ ‘κ·Όμ„± 있게 λΉ„ν™œμ„±ν™” μƒνƒœμ™€ κ·Έ 이유λ₯Ό 전달할 수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ“Έ Before/After: (N/A) 슀크린 리더 및 ν‚€λ³΄λ“œ μ‚¬μš©μ„± μœ„μ£Όμ˜ λ³€κ²½μœΌλ‘œ UI 외관상 μ°¨μ΄λŠ” μ—†μœΌλ‚˜, 툴팁 ν‘œμ‹œ 방식이 κ°œμ„ λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
β™Ώ Accessibility: λΉ„ν™œμ„±ν™”λœ λ²„νŠΌμ„ span λž˜νΌμ— role="button"κ³Ό ν•¨κ»˜ λ‘λŠ” 방식(λ„€μ΄ν‹°λΈŒ λ²„νŠΌμ„ ν¬ν•¨ν•˜λŠ” 잘λͺ»λœ 쀑첩)을 μ œκ±°ν•˜κ³ , λ²„νŠΌ μžμ²΄μ— aria-disabled="true"와 title 속성을 두어 슀크린 리더와 μ‹œκ°μ  툴팁 μ–‘μͺ½ λͺ¨λ‘μ—μ„œ μ •ν™•ν•œ μƒνƒœλ₯Ό μ „λ‹¬ν•˜κ²Œ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 16420223422450782798 started by @seonghobae

- `apps/desktop/src/components/ui/button.tsx`에 `aria-disabled`에 λŒ€ν•œ `hover` μŠ€νƒ€μΌ μΆ”κ°€
- `apps/desktop/src/App.tsx`μ—μ„œ λΉ„ν™œμ„±ν™”λœ μ €μž₯ λ²„νŠΌμ„ κ°μ‹Έλ˜ λΆˆν•„μš”ν•œ `span` 래퍼 제거 및 `aria-disabled` 속성을 λ²„νŠΌμ— 직접 적용
- 툴팁 및 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± μœ μ§€
- μ—°κ΄€λœ `App.test.tsx` ν…ŒμŠ€νŠΈ μ½”λ“œ μ—…λ°μ΄νŠΈ
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- `apps/desktop/src/components/ui/button.tsx`에 `aria-disabled`에 λŒ€ν•œ `hover` μŠ€νƒ€μΌ μΆ”κ°€
- `apps/desktop/src/App.tsx`μ—μ„œ λΉ„ν™œμ„±ν™”λœ μ €μž₯ λ²„νŠΌμ„ κ°μ‹Έλ˜ λΆˆν•„μš”ν•œ `span` 래퍼 제거 및 `aria-disabled` 속성을 λ²„νŠΌμ— 직접 적용
- 툴팁 및 ν‚€λ³΄λ“œ μ ‘κ·Όμ„± μœ μ§€
- μ—°κ΄€λœ `App.test.tsx` ν…ŒμŠ€νŠΈ μ½”λ“œ μ—…λ°μ΄νŠΈ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant