π¨ Palette: [UX improvement] νλ‘μ νΈ μ μ₯ λ²νΌμ ν΄ν μ κ·Όμ± κ°μ #636
π¨ Palette: [UX improvement] νλ‘μ νΈ μ μ₯ λ²νΌμ ν΄ν μ κ·Όμ± κ°μ #636seonghobae wants to merge 2 commits into
Conversation
- `apps/desktop/src/components/ui/button.tsx`μ `aria-disabled`μ λν `hover` μ€νμΌ μΆκ° - `apps/desktop/src/App.tsx`μμ λΉνμ±νλ μ μ₯ λ²νΌμ κ°μΈλ λΆνμν `span` λνΌ μ κ±° λ° `aria-disabled` μμ±μ λ²νΌμ μ§μ μ μ© - ν΄ν λ° ν€λ³΄λ μ κ·Όμ± μ μ§ - μ°κ΄λ `App.test.tsx` ν μ€νΈ μ½λ μ λ°μ΄νΈ
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- `apps/desktop/src/components/ui/button.tsx`μ `aria-disabled`μ λν `hover` μ€νμΌ μΆκ° - `apps/desktop/src/App.tsx`μμ λΉνμ±νλ μ μ₯ λ²νΌμ κ°μΈλ λΆνμν `span` λνΌ μ κ±° λ° `aria-disabled` μμ±μ λ²νΌμ μ§μ μ μ© - ν΄ν λ° ν€λ³΄λ μ κ·Όμ± μ μ§ - μ°κ΄λ `App.test.tsx` ν μ€νΈ μ½λ μ λ°μ΄νΈ
π‘ What: λΉνμ±νλ "νλ‘μ νΈ μ μ₯" λ²νΌμ ν΄ν μ κ·Όμ± κ°μ λ° λΆνμν DOM λνΌ μ κ±°
π― Why: λ€μ΄ν°λΈ
<button disabled>λ₯Ό ν΄νμ©spanμΌλ‘ κ°μΈλ λ°©μμ ARIA μ¬μ μλ°μ μμ§κ° μμΌλ©°, μ½λλ₯Ό 볡μ‘νκ² λ§λλλ€.aria-disabled="true"λ₯Ό μ§μ λ²νΌμ μ¬μ©νλ©΄ ν¬μ»€μ€ μ΄λμ νμ©νλ©΄μ μ κ·Όμ± μκ² λΉνμ±ν μνμ κ·Έ μ΄μ λ₯Ό μ λ¬ν μ μμ΅λλ€.πΈ Before/After: (N/A) μ€ν¬λ¦° 리λ λ° ν€λ³΄λ μ¬μ©μ± μμ£Όμ λ³κ²½μΌλ‘ UI μΈκ΄μ μ°¨μ΄λ μμΌλ, ν΄ν νμ λ°©μμ΄ κ°μ λμμ΅λλ€.
βΏ Accessibility: λΉνμ±νλ λ²νΌμ
spanλνΌμrole="button"κ³Ό ν¨κ» λλ λ°©μ(λ€μ΄ν°λΈ λ²νΌμ ν¬ν¨νλ μλͺ»λ μ€μ²©)μ μ κ±°νκ³ , λ²νΌ μ체μaria-disabled="true"μtitleμμ±μ λμ΄ μ€ν¬λ¦° 리λμ μκ°μ ν΄ν μμͺ½ λͺ¨λμμ μ νν μνλ₯Ό μ λ¬νκ² νμμ΅λλ€.PR created automatically by Jules for task 16420223422450782798 started by @seonghobae